"Search Plugins" not being installed on Mac (if JAR packaging enabled)

VERIFIED FIXED

Status

SeaMonkey
Build Config
P3
major
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Robert John Churchill, Assigned: Warren Harris)

Tracking

Trunk
PowerPC
All

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rtm++][fix in hand])

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
It appears that with both the tip and branch, the "Search Plugins" directory 
isn't being created and doesn't get copies of the installed Sherlock search 
files... it looks like this probably broke when JAR packaging was enabled for the 
Mac.

Basically, the following couple of lines probably need to be copied elsewhere so 
that they get executed when JAR packaging is on:
http://lxr.mozilla.org/seamonkey/source/build/mac/NGLayoutBuildList.pm#1200

Search won't work on the Mac until this is fixed... so marking "nsbeta3" and 
"rtm".
(Reporter)

Updated

18 years ago
Keywords: nsbeta3, rtm

Comment 1

17 years ago
per new pdt rules... this one is a [rtm need info] once a patch/fix is ready 
change this to [rtm+]
Whiteboard: [rtm need info]

Updated

17 years ago
Keywords: nsbeta3
(Reporter)

Comment 2

17 years ago
Created attachment 16171 [details] [diff] [review]
Proposed patch (needs to be changed in both Mozilla & Netscape trees)
(Reporter)

Comment 3

17 years ago
I've attached a patch to try and fix this problem with the build scripts.

cc'ing sfraser also

Simon & Warren, can you review/text the patch I've attached.  Without it, no 
"Search Plugins" folder is created on the Mac.  With it, a "Search Plugins" 
folder is created and populated with all the listed search plugins.
(Reporter)

Comment 4

17 years ago
Note: This needs to be fixed in both the Mozilla trunk, branch, and Netscape 
commercial trees.
(Assignee)

Comment 5

17 years ago
Looks ok to me.

Comment 6

17 years ago
Patch is bad -- it's in the wrong place. It should live in 
InstallNonChromeResources(), not InstallComponentFiles().
(Reporter)

Comment 7

17 years ago
Created attachment 16187 [details] [diff] [review]
Ah, OK... same fix, ran from different location

Comment 8

17 years ago
r=sfraser
(Reporter)

Updated

17 years ago
Whiteboard: [rtm need info] → [rtm+][fix in hand]

Comment 9

17 years ago
Who was the super reviewer on this?  Please delete the "need info" when you've
got one for ++ reevaluation
Whiteboard: [rtm+][fix in hand] → [rtm+ need info][fix in hand]

Comment 10

17 years ago
r=warren, sr=sfraser (or vice versa).
(Reporter)

Updated

17 years ago
Whiteboard: [rtm+ need info][fix in hand] → [rtm+][fix in hand]

Comment 11

17 years ago
PDT marking [rtm++]
Whiteboard: [rtm+][fix in hand] → [rtm++][fix in hand]
(Reporter)

Comment 12

17 years ago
Fixed on both tip and branch.

Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 13

17 years ago
marking verified.
Status: RESOLVED → VERIFIED
OS: All
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.