Last Comment Bug 543239 - Filter list no longer finds and selects filter using keyboard entry.
: Filter list no longer finds and selects filter using keyboard entry.
: regression
Product: MailNews Core
Classification: Components
Component: Filters (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 19.0
Assigned To: :aceman
Depends on:
Blocks: 800091
  Show dependency treegraph
Reported: 2010-01-30 11:39 PST by Kent James (:rkent)
Modified: 2012-10-22 16:55 PDT (History)
6 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (2.34 KB, patch)
2012-10-03 12:02 PDT, :aceman
bwinton: ui‑review+
Details | Diff | Splinter Review
patch v2 (2.04 KB, patch)
2012-10-20 16:10 PDT, :aceman
mkmelin+mozilla: review+
Details | Diff | Splinter Review
patch v3 (2.04 KB, patch)
2012-10-21 06:44 PDT, :aceman
acelists: review+
Details | Diff | Splinter Review

Description User image Kent James (:rkent) 2010-01-30 11:39:35 PST
From, you can no longer quickly select a filter in a filter list by entering the first few characters of the filter's name.
Comment 1 User image :aceman 2012-10-03 06:18:42 PDT
Rkent, bwinton, should we really implement this in addition to the new search box, or can we just focus the search box and let it get the entered characters?
Comment 2 User image Kent James (:rkent) 2012-10-03 07:25:41 PDT
I think that the search box fulfills the requirement without the need for more work.
Comment 3 User image :aceman 2012-10-03 08:08:05 PDT
I can try to focus the searchbox when any character key is pressed on the filter list.
Comment 4 User image :aceman 2012-10-03 12:02:49 PDT
Created attachment 667588 [details] [diff] [review]

Something like this.
Comment 5 User image Kent James (:rkent) 2012-10-10 07:35:01 PDT
Comment on attachment 667588 [details] [diff] [review]

Sorry for the slow response on this - had a hard time keeping my comm-central builds going.

Looking at it though, this is really more front-end /mail focused, so I am going to defer to Magnus.
Comment 6 User image Blake Winton (:bwinton) (:☕️) 2012-10-10 12:07:53 PDT
Comment on attachment 667588 [details] [diff] [review]

I like it, although I would like it a little more if we could indicate when a filter search failed, perhaps with a red outline around the search box, or by showing nothing in the filter list?

Although that is starting to sound like a different bug, so ui-r=me for this one.

Comment 7 User image Magnus Melin 2012-10-11 12:57:25 PDT
Comment on attachment 667588 [details] [diff] [review]

Review of attachment 667588 [details] [diff] [review]:

bitrotten (soon) by your patch in bug 783491
Comment 8 User image :aceman 2012-10-20 16:10:36 PDT
Created attachment 673637 [details] [diff] [review]
patch v2
Comment 9 User image Magnus Melin 2012-10-21 02:44:12 PDT
Comment on attachment 673637 [details] [diff] [review]
patch v2

Review of attachment 673637 [details] [diff] [review]:

Thx, r=mkmelin

::: mail/base/content/FilterListDialog.js
@@ +808,2 @@
>      }
> +  } else if (!aEvent.ctrlKey && !aEvent.altKey && !aEvent.metaKey) {

would prefer else if on new line
Comment 10 User image :aceman 2012-10-21 06:44:38 PDT
Created attachment 673687 [details] [diff] [review]
patch v3
Comment 11 User image Ryan VanderMeulen [:RyanVM] 2012-10-22 16:55:21 PDT

Note You need to log in before you can comment on or make changes to this bug.