Filter list no longer finds and selects filter using keyboard entry.

RESOLVED FIXED in Thunderbird 19.0

Status

MailNews Core
Filters
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: rkent, Assigned: aceman)

Tracking

({regression})

Trunk
Thunderbird 19.0
regression
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [filter-mgmt])

Attachments

(1 attachment, 2 obsolete attachments)

2.04 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
From https://bugzilla.mozilla.org/show_bug.cgi?id=526048#c2, you can no longer quickly select a filter in a filter list by entering the first few characters of the filter's name.
(Assignee)

Updated

6 years ago
Summary: Filter list no longer selects filter using keyboard entry. → Filter list no longer finds and selects filter using keyboard entry.
Whiteboard: [filter-mgmt]
(Assignee)

Comment 1

5 years ago
Rkent, bwinton, should we really implement this in addition to the new search box, or can we just focus the search box and let it get the entered characters?
(Reporter)

Comment 2

5 years ago
I think that the search box fulfills the requirement without the need for more work.
(Assignee)

Comment 3

5 years ago
I can try to focus the searchbox when any character key is pressed on the filter list.
Assignee: nobody → acelists
(Assignee)

Comment 4

5 years ago
Created attachment 667588 [details] [diff] [review]
patch

Something like this.
Attachment #667588 - Flags: ui-review?(bwinton)
Attachment #667588 - Flags: review?(kent)
Attachment #667588 - Flags: feedback?(axelg)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
(Reporter)

Comment 5

5 years ago
Comment on attachment 667588 [details] [diff] [review]
patch

Sorry for the slow response on this - had a hard time keeping my comm-central builds going.

Looking at it though, this is really more front-end /mail focused, so I am going to defer to Magnus.
Attachment #667588 - Flags: review?(kent) → review?(mkmelin+mozilla)
Comment on attachment 667588 [details] [diff] [review]
patch

I like it, although I would like it a little more if we could indicate when a filter search failed, perhaps with a red outline around the search box, or by showing nothing in the filter list?

Although that is starting to sound like a different bug, so ui-r=me for this one.

Thanks,
Blake.
Attachment #667588 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Blocks: 800091

Comment 7

5 years ago
Comment on attachment 667588 [details] [diff] [review]
patch

Review of attachment 667588 [details] [diff] [review]:
-----------------------------------------------------------------

bitrotten (soon) by your patch in bug 783491
Attachment #667588 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 8

5 years ago
Created attachment 673637 [details] [diff] [review]
patch v2
Attachment #667588 - Attachment is obsolete: true
Attachment #667588 - Flags: feedback?(axelg)
Attachment #673637 - Flags: review?(mkmelin+mozilla)

Comment 9

5 years ago
Comment on attachment 673637 [details] [diff] [review]
patch v2

Review of attachment 673637 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, r=mkmelin

::: mail/base/content/FilterListDialog.js
@@ +808,2 @@
>      }
> +  } else if (!aEvent.ctrlKey && !aEvent.altKey && !aEvent.metaKey) {

would prefer else if on new line
Attachment #673637 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 10

5 years ago
Created attachment 673687 [details] [diff] [review]
patch v3
Attachment #673637 - Attachment is obsolete: true
Attachment #673687 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9a091add30b2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
You need to log in before you can comment on or make changes to this bug.