54326 - HTML Mail Question dialog have no radio nor button

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Frank Tang]

This is using Window commercial Netscape 6 bulid 2000092408
on Window NT4 with classic theme. (not sure about moderm theme yet)

repreduce procedure
1. launch Netscape6
2. Select "Task:Mail"
3. Select "File:New Message"
4. type some text and send the mail out
5. a "HTML Mail Question" dialog box show up to ask me
Send in Plain Text and HTML
Send in Plain Text Only
Send in HTML Only

Expect result-
These three option in radio and there are two button "Send" and "Don't Send"

Actual result-
the text of these three are display without radio. The button text display but
there are no button to press.

Comment 1

[Frank Tang]

mark it as dogfood. I cannot send out my mail. The dialog box won't go away 
unless I click on the close box in the window deco. But the message won't send 
out if I do so.

Comment 2

[Frank Tang]

This problem is not in Modern theme.

Comment 3

[Matthew T (active 1999-2002)]

Could be a dup of bug 54302.

Comment 4

[Jean-Francois Ducarroz]

As the buttons are also broken, looks like more that the css file failed to 
load. I thought this bug was already solved :-(

When this problem occurs, can you give me the content of the console. At least 
the last 2 pages. Thanks

Comment 5

[laurel]

*** Bug 54395 has been marked as a duplicate of this bug. ***

Comment 6

[Frank Tang]

This is happen on 20000927 win/mac/linux build. All with classic theme. The
difference on mac is the "Don't send Send" text shown as right align. On
linux/Window, it is centered.

The button text is functional. If I click on it will now send or don't send now.
However, it don't look like a button so probably no user will click on it.

Comment 7

[lchiang]

nominate for nsbeta3.  Steve, Scott - what do you think?  We only have Thursday 
to get this fixed if we want consideration for this to be in nsbeta3.  For 
people using classic, this is a dialog that is very common to be seen and the 
bad thing is that folks won't know how to send a message (ie. no buttons).

Comment 8

[kmurray1115]

If this can get in tomorrow, I say go for it.

Comment 9

[selmer (gone)]

OK, giving nsbeta3+, but we need the PDT to agree & approve.  Adding hangas to
the CC.

Paul, can you verify whether this is skins related?  Thx.

Comment 10

[hangas]

I see about two of these a day.  If when tested on a different speed machine with 
the same build of N6 the problem does not happen the same way, then this is 
probably a case of bug 52390.  If the problem repeats on Windows Classic and 
Linux Classic on machines of different speeds then this may be (all or part) a 
different bug.

Comment 11

[Jim Roskind]

Assuming Frank's comment represents consistent problems (always fails for him),
I'm giving this dogfood-plus status.
If this is really intermittent for folks, then it should be downgraded (you just
say "don't send" and get a good dialog the next time).

Comment 12

[selmer (gone)]

Fenella, given Paul's comments, can you look at this with the most recent build
and let us know what state it's currently in?  If this is a dup of 52390
, it would be good to know that ASAP so we can lend weight to that bug for
nsbeta3++ (it's currently only rtm+.)

Comment 13

[Jean-Francois Ducarroz]

I am pretty sure it's a dup of bug 52390

Comment 14

[Jean-Francois Ducarroz]

*** This bug has been marked as a duplicate of 52390 ***

Comment 15

[Ninoschka Baca]

Fenella, Using the Classic skin I reproduced the problem on the following
systems. I can keep an eye on this today to see if this changes:

- NT4, 128MB RAM, Branch build 2000-09-27-11MN6
- Linux 6.0, 64MB RAM, Branch build 2000-09-27-10MN6
- Mac 9.04, 256MB RAM, Branch build 2000-09-27-11MN6

Comment 16

[Tracy Walker [:tracy]]

this has been working fine on all platforms today

commercial builds:
windows 2000-09-28-06-M18 & 2000-09-28-08-MN6
linux 2000-09-28-06-M18 & 2000-09-28-10-MN6
mac 2000-09-28-12-MN6

Comment 17

[fenella]

Mac (2000-09-28-10 MN6)
Win32 (2000-09-28-09 MN6)
Mac 2000-09-28-10 MN6)
Using Modern Skin, this problem does not exist
But using Classic skin, this problem still exist on all platforms.

Thanks Ninoschka for keeping an eye on it too.

Comment 18

[Tracy Walker [:tracy]]

reopening per lchiang.

this is on all platforms branch and trunk builds in classic skin

note:  clicking on the text is a useable workaround, or go to modern theme

Comment 19

[Ben Bucksch (:BenB)]

worksforme with 2000-09-27 nightly and my own build just built. Linux, both skins.

Comment 20

[Jean-Francois Ducarroz]

I don't see the problem with a Mozilla branch debug from this morning on Windows. However, I see it with a Windows 
Commercial Release build from today in Classic theme only (2000-10-02-09-MN6).

Comment 21

[Asa Dotzler [:asa]]

this does not appear to be a problem in mozilla win32 trunk or branch builds
100204 or mozilla mac or linux builds 10028.  Perhaps it is limited to commercial.

Comment 22

[Jean-Francois Ducarroz]

ok, I found the problem. This occurs only with commercial build using Jar 
packaking and with Classic theme. For some reason, Ben removed the import of 
messenger.css from messengercompose.css. Therefore the dialog which include only 
messenger.css doesn't have access to the default chrome!

In Mozilla build, this doesn't occurs because the new askSendFormat dialog does 
include both css file itself. The Commercial build doesn't use the new dialog 
because of bug 51547.

Comment 23

[Jean-Francois Ducarroz]

Ben was right when he removed messenger.css from messengercompose.css. However, 
we must instead include chrome://communicator/skin/ instead.

Comment 24

[Jean-Francois Ducarroz]

Here is the minimum fix:

Index: messengercompose.css
===================================================================
RCS file:
/cvsroot/mozilla/themes/classic/messenger/messengercompose/messengercompose.css,v
retrieving revision 1.11
diff -b -u -2 -r1.11 messengercompose.css
--- messengercompose.css	2000/09/12 20:38:12	1.11
+++ messengercompose.css	2000/10/02 21:11:34
@@ -1,2 +1,24 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
+ * The contents of this file are subject to the Netscape Public
+ * License Version 1.1 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.mozilla.org/NPL/
+ *
+ * Software distributed under the License is distributed on an "AS
+ * IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ * implied. See the License for the specific language governing
+ * rights and limitations under the License.
+ *
+ * The Original Code is Mozilla Communicator client code, released
+ * March 31, 1998.
+ *
+ * The Initial Developer of the Original Code is Netscape
+ * Communications Corporation. Portions created by Netscape are
+ * Copyright (C) 1998-1999 Netscape Communications Corporation. All
+ * Rights Reserved.
+ */
+
+@import url(chrome://communicator/skin/);
+
 @namespace
url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"); /* set
default namespace to HTML */
 @namespace html url("http://www.w3.org/1999/xhtml"); /* namespace for HTML
elements */


Here is the full fix which cleanup the mess with those css file usage in message
compose in Classic and Modern:

Index: messengercompose.css
===================================================================
RCS file:
/cvsroot/mozilla/themes/modern/messenger/messengercompose/messengercompose.css,v
retrieving revision 1.14
diff -b -u -2 -r1.14 messengercompose.css
--- messengercompose.css	2000/09/15 06:23:18	1.14
+++ messengercompose.css	2000/10/02 21:13:22
@@ -1,3 +1,23 @@
-@import url(chrome://messenger/skin/messenger.css);
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
+ * The contents of this file are subject to the Netscape Public
+ * License Version 1.1 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.mozilla.org/NPL/
+ *
+ * Software distributed under the License is distributed on an "AS
+ * IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ * implied. See the License for the specific language governing
+ * rights and limitations under the License.
+ *
+ * The Original Code is Mozilla Communicator client code, released
+ * March 31, 1998.
+ *
+ * The Initial Developer of the Original Code is Netscape
+ * Communications Corporation. Portions created by Netscape are
+ * Copyright (C) 1998-1999 Netscape Communications Corporation. All
+ * Rights Reserved.
+ */
+
+@import url(chrome://communicator/skin/);

 @namespace
url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"); /* set
default namespace to HTML */

Index: messengercompose.css
===================================================================
RCS file:
/cvsroot/mozilla/themes/classic/messenger/messengercompose/messengercompose.css,v
retrieving revision 1.11
diff -b -u -2 -r1.11 messengercompose.css
--- messengercompose.css	2000/09/12 20:38:12	1.11
+++ messengercompose.css	2000/10/02 21:14:18
@@ -1,2 +1,24 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
+ * The contents of this file are subject to the Netscape Public
+ * License Version 1.1 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.mozilla.org/NPL/
+ *
+ * Software distributed under the License is distributed on an "AS
+ * IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ * implied. See the License for the specific language governing
+ * rights and limitations under the License.
+ *
+ * The Original Code is Mozilla Communicator client code, released
+ * March 31, 1998.
+ *
+ * The Initial Developer of the Original Code is Netscape
+ * Communications Corporation. Portions created by Netscape are
+ * Copyright (C) 1998-1999 Netscape Communications Corporation. All
+ * Rights Reserved.
+ */
+
+@import url(chrome://communicator/skin/);
+
 @namespace
url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"); /* set
default namespace to HTML */
 @namespace html url("http://www.w3.org/1999/xhtml"); /* namespace for HTML
elements */

Index: askSendFormat.xul
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/resources/content/askSendFormat.xul,v
retrieving revision 1.13
diff -b -u -2 -r1.13 askSendFormat.xul
--- askSendFormat.xul	2000/09/14 04:55:07	1.13
+++ askSendFormat.xul	2000/10/02 21:14:33
@@ -1,5 +1,4 @@
 <?xml version="1.0"?><!-- -*- Mode: SGML; tab-width: 4; indent-tabs-mode: nil;
-*- -->

-<?xml-stylesheet href="chrome://messenger/skin/messenger.css" type="text/css"?>
 <?xml-stylesheet
href="chrome://messenger/skin/messengercompose/messengercompose.css"
type="text/css"?>

Comment 25

[Jean-Francois Ducarroz]

Looks like is too late for PR3. But we must correct this major problem asap. 
Therefore, I nominated it for rtm.

Comment 26

[selmer (gone)]

rtm+ need info, please get review and super review.  Once the process is
complete, remove the "need info" portion of the approval so we'll see it again.

Comment 27

[(not reading, please use [e-mail] instead)]

r=sspitzer

Comment 28

[Ben Bucksch (:BenB)]

> Ben removed the import of messenger.css from messengercompose.css

Ben Goodger, not me, right?

> + [...] , released
> + * March 31, 1998.

Please remove this. The CSS files were not released 1998.

Comment 29

[Ben Goodger (use ben at mozilla dot org for email)]

a=ben for the change. 

Comment 30

[Jean-Francois Ducarroz]

fix ready to go, waiting on PDT to ++ this bug.

Comment 31

[Phil Peterson]

PDT marking [rtm++]

Comment 32

[Jean-Francois Ducarroz]

Fixed and checked in Trunk & Branch

Comment 33

[Tracy Walker [:tracy]]

verified fixed on commercial builds:

windows 2000-10-04-09-M18
linux 2000-10-04-08-M18
mac 2000-10-04-08-M18