Closed
Bug 543274
Opened 14 years ago
Closed 14 years ago
Support for stubbed debugger
Categories
(Tamarin Graveyard :: Virtual Machine, enhancement, P2)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: alexmac, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
7.21 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_2; en-us) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10 Build Identifier: HEAD For AOT'ed flash content we always compile the runtime with DEBUGGER defined. Depending on whether an end user is building for deployment or testing they can then choose to link in the real debugger or a no-op stubbed version. This patch adds support for compiling with DEBUGGER enabled, but without any of the error strings defined, resulting in a much smaller binary. This is done by enabling AVMFEATURE_DEBUGGER_STUB. In the future we might also want to turn off / refactor more of the debugger so that enabling just the API comes with as little overhead as possible. Reproducible: Always
Reporter | ||
Comment 1•14 years ago
|
||
Attachment #424450 -
Flags: review?(stejohns)
Updated•14 years ago
|
Attachment #424450 -
Flags: review?(stejohns) → review+
Comment 2•14 years ago
|
||
Comment on attachment 424450 [details] [diff] [review] Support for stubbed debugger changing to r- after further review: -- the declaration of findErrorMessage() in AvmCore.h should also be #ifndef VMCFG_DEBUGGER_STUB -- ErrorConstants.h/.cpp have prominent notes at the top saying "THIS FILE IS AUTO-GENERATED. DO NOT EDIT THIS FILE"
Attachment #424450 -
Flags: review+ → review-
Reporter | ||
Comment 3•14 years ago
|
||
Attachment #424450 -
Attachment is obsolete: true
Attachment #424454 -
Flags: review?(stejohns)
Reporter | ||
Comment 4•14 years ago
|
||
(In reply to comment #2) > (From update of attachment 424450 [details] [diff] [review]) > changing to r- after further review: > > -- the declaration of findErrorMessage() in AvmCore.h should also be #ifndef > VMCFG_DEBUGGER_STUB fixed > > -- ErrorConstants.h/.cpp have prominent notes at the top saying "THIS FILE IS > AUTO-GENERATED. DO NOT EDIT THIS FILE" My patch modified errorgen.as so I recompiled errorgen.abc and after running it it re-generated those files with my fixes applied.
Updated•14 years ago
|
Attachment #424454 -
Flags: review?(stejohns) → review+
Comment 5•14 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/570bc8b82912
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: flashplayer-qrb+
Priority: -- → P2
Target Milestone: --- → flash10.1
Comment 6•14 years ago
|
||
Looks like part of the patch for build/avmfeatures.py was not included. diff -r b0095a29c958 build/avmfeatures.py --- a/build/avmfeatures.py Tue Feb 09 07:59:47 2010 -0500 +++ b/build/avmfeatures.py Tue Feb 09 09:10:56 2010 -0500 @@ -50,6 +50,11 @@ args += "-DAVMFEATURE_DEBUGGER=1 " if (arg == False): args += "-DAVMFEATURE_DEBUGGER=0 " + arg = o.getBoolArg("debugger-stub") + if (arg == True): + args += "-DAVMFEATURE_DEBUGGER_STUB=1 " + if (arg == False): + args += "-DAVMFEATURE_DEBUGGER_STUB=0 " arg = o.getBoolArg("allocation-sampler") if (arg == True): args += "-DAVMFEATURE_ALLOCATION_SAMPLER=1 "
Comment 7•14 years ago
|
||
build/avmfeatures.py patched in argo w/ changeset 3711 77aaca5caa3f
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•