543299 - Sinhala (si) Thunderbird has whitespace at the top of install.rdf

Status: RESOLVED FIXED

(Mozilla Localizations :: si / Sinhala, defect)

Description

[Micah Gersten]

In the comm-1.9.1 nightly language pack for fy-NL, the install.rdf has 3 extra lines at the top which is illegal XML.  This is also a problem for the TB 3.0 version.  This seems to be fixed on the comm-central 3.2a1pre language pack.

Comment 1

[Micah Gersten]

(In reply to comment #0)
> In the comm-1.9.1 nightly language pack for fy-NL, the install.rdf has 3 extra
> lines at the top which is illegal XML.  This is also a problem for the TB 3.0
> version.  This seems to be fixed on the comm-central 3.2a1pre language pack.

I meant si, not fy-NL in this bug...

Comment 2

[Micah Gersten]

Poke...been over 2 months with no update

Comment 3

[Micah Gersten]

This is still occurring in the Thunderbird 3.1.2 xpis.

Comment 4

[Mark Banner (:standard8)]

Does this happen on languages other than si or in the Firefox xpis?

AFAICT Thunderbird is using pretty much the same generation code as Firefox.

Comment 5

[Axel Hecht [:Pike]]

Looking at the install.rdf, it's likely the DOS line endings in mail/defines.inc, moving over to the sinhala component.

Comment 6

[Christoph Göhre]

Attachment: remove empty lines on top of si/install.rdf

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 490457 [details] [diff] [review]
remove empty lines on top of si/install.rdf

Christoph, that file is generated, there's nothing to patch in there.

As I mentioned before, this is more likely to be an issue with the line endings in the files that go in, namely mail/defines.inc, in the l10n-mozilla-1.9.2/si repo (and l10n-central, probably, too).

Didn't verify that, though.

Comment 8

[Christoph Göhre]

Attachment: change CRLF to LF

Comment 9

[Christoph Göhre]

(In reply to comment #7)
> As I mentioned before, this is more likely to be an issue with the line endings
> in the files that go in, namely mail/defines.inc, in the l10n-mozilla-1.9.2/si
> repo (and l10n-central, probably, too).

I've change the line endings from CRLF to LF. See new patch. Hope, that is fine now.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 498497 [details] [diff] [review]
change CRLF to LF

I suspect this should work, but Danishka should really take the review here, and the landing, too, if r+.

Comment 11

[Danishka]

Comment on attachment 498497 [details] [diff] [review]
change CRLF to LF

this is ok for me

Comment 12

[Christoph Göhre]

Sorry, I couldn't add the keyword 'checkin-needed', but someone need to push my patch into hg.

Comment 13

[Ed Morley [:emorley]]

Bump for checkin-needed.

Comment 14

[Ed Morley [:emorley]]

Bump, this still needs checking in.

Comment 15

[Jonathan Protzenko [:protz]]

jonathan@ramona:~/Code/comm-central $ hg import --no-commit "https://bugzilla.mozilla.org/attachment.cgi?id=498497"
applying https://bugzilla.mozilla.org/attachment.cgi?id=498497
unable to find 'mail/defines.inc' for patching
1 out of 1 hunks FAILED -- saving rejects to file mail/defines.inc.rej
abort: patch failed to apply

Can't checkin this, you need to post an updated patch that applies cleanly on comm-central tip ; removing checkin-needed.

Comment 16

[Mark Banner (:standard8)]

(In reply to comment #15)
> Can't checkin this, you need to post an updated patch that applies cleanly
> on comm-central tip ; removing checkin-needed.

This isn't for comm-central, it is for this repository:

http://hg.mozilla.org/l10n-central/si/ and/or http://hg.mozilla.org/releases/l10n/mozilla-aurora/si/

(which only l10n folks have access to).

Comment 17

[Jonathan Protzenko [:protz]]

Oh ok. I thought that since there was Thunderbird in the bug title it was meant for comm-central. My bad :-)

Comment 18

[Mark Banner (:standard8)]

I just pushed this to the si aurora repository on behalf of Christoph and after checking with Rohana:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/si/rev/949c103dbdaf