Closed Bug 543299 Opened 10 years ago Closed 8 years ago

Sinhala (si) Thunderbird has whitespace at the top of install.rdf

Categories

(Mozilla Localizations :: si / Sinhala, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: mozilla-bugs, Assigned: chris)

Details

Attachments

(1 file, 1 obsolete file)

In the comm-1.9.1 nightly language pack for fy-NL, the install.rdf has 3 extra lines at the top which is illegal XML.  This is also a problem for the TB 3.0 version.  This seems to be fixed on the comm-central 3.2a1pre language pack.
(In reply to comment #0)
> In the comm-1.9.1 nightly language pack for fy-NL, the install.rdf has 3 extra
> lines at the top which is illegal XML.  This is also a problem for the TB 3.0
> version.  This seems to be fixed on the comm-central 3.2a1pre language pack.

I meant si, not fy-NL in this bug...
Poke...been over 2 months with no update
Component: si / Sinhala → Release Engineering
Product: Mozilla Localizations → Mozilla Messaging
QA Contact: sinhala.si → release
Version: unspecified → other
This is still occurring in the Thunderbird 3.1.2 xpis.
Does this happen on languages other than si or in the Firefox xpis?

AFAICT Thunderbird is using pretty much the same generation code as Firefox.
Looking at the install.rdf, it's likely the DOS line endings in mail/defines.inc, moving over to the sinhala component.
Component: Release Engineering → si / Sinhala
Product: Mozilla Messaging → Mozilla Localizations
QA Contact: release → sinhala.si
Version: other → unspecified
Summary: Sinhala (si) has whitespace at the top of install.rdf → Sinhala (si) Thunderbird has whitespace at the top of install.rdf
Attachment #490457 - Flags: review?(l10n)
Comment on attachment 490457 [details] [diff] [review]
remove empty lines on top of si/install.rdf

Christoph, that file is generated, there's nothing to patch in there.

As I mentioned before, this is more likely to be an issue with the line endings in the files that go in, namely mail/defines.inc, in the l10n-mozilla-1.9.2/si repo (and l10n-central, probably, too).

Didn't verify that, though.
Attachment #490457 - Flags: review?(l10n) → review-
Attachment #490457 - Attachment is obsolete: true
Attachment #498497 - Flags: review?(l10n)
(In reply to comment #7)
> As I mentioned before, this is more likely to be an issue with the line endings
> in the files that go in, namely mail/defines.inc, in the l10n-mozilla-1.9.2/si
> repo (and l10n-central, probably, too).

I've change the line endings from CRLF to LF. See new patch. Hope, that is fine now.
Comment on attachment 498497 [details] [diff] [review]
change CRLF to LF

I suspect this should work, but Danishka should really take the review here, and the landing, too, if r+.
Attachment #498497 - Flags: review?(l10n)
Attachment #498497 - Flags: review?(danishka)
Attachment #498497 - Flags: feedback+
Attachment #498497 - Flags: review?(danishka) → review+
Comment on attachment 498497 [details] [diff] [review]
change CRLF to LF

this is ok for me
Sorry, I couldn't add the keyword 'checkin-needed', but someone need to push my patch into hg.
Keywords: checkin-needed
Assignee: nobody → chris
Bump for checkin-needed.
Status: NEW → ASSIGNED
Bump, this still needs checking in.
OS: Linux → All
Hardware: x86 → All
jonathan@ramona:~/Code/comm-central $ hg import --no-commit "https://bugzilla.mozilla.org/attachment.cgi?id=498497"
applying https://bugzilla.mozilla.org/attachment.cgi?id=498497
unable to find 'mail/defines.inc' for patching
1 out of 1 hunks FAILED -- saving rejects to file mail/defines.inc.rej
abort: patch failed to apply

Can't checkin this, you need to post an updated patch that applies cleanly on comm-central tip ; removing checkin-needed.
Keywords: checkin-needed
(In reply to comment #15)
> Can't checkin this, you need to post an updated patch that applies cleanly
> on comm-central tip ; removing checkin-needed.

This isn't for comm-central, it is for this repository:

http://hg.mozilla.org/l10n-central/si/ and/or http://hg.mozilla.org/releases/l10n/mozilla-aurora/si/

(which only l10n folks have access to).
Keywords: checkin-needed
Oh ok. I thought that since there was Thunderbird in the bug title it was meant for comm-central. My bad :-)
I just pushed this to the si aurora repository on behalf of Christoph and after checking with Rohana:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/si/rev/949c103dbdaf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.