Remove unused toolbarmode and buttonstyle attributes

RESOLVED FIXED in mozilla1.9.3a1

Status

()

--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 424473 [details] [diff] [review]
patch
Attachment #424473 - Flags: review?(neil)

Comment 1

9 years ago
Comment on attachment 424473 [details] [diff] [review]
patch

>-toolbarbutton:hover:active[buttonstyle="text"],
>-toolbarbutton[open="true"][buttonstyle="text"] {
Confusingly buttonstyle has become mode; toolbarmode became iconsize. Unfortunately this is in pinstripe so I can't tell whether it is correct to delete this or whether it should have switched to using mode instead. Given that the rule was never used, it seems unlikely, but I'd appreciate it if you could get a second opinion. r=me for toolbarbutton.xml either way.
Attachment #424473 - Flags: review?(neil) → review+
(Assignee)

Updated

9 years ago
Attachment #424473 - Flags: review?(rflint)
Comment on attachment 424473 [details] [diff] [review]
patch

Anyone seeking blue text in pinstripe is probably already doing the styling themselves. r=me.
Attachment #424473 - Flags: review?(rflint) → review+
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/ca5c79a77bd0
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.