Closed Bug 543317 Opened 14 years ago Closed 14 years ago

Remove unused toolbarmode and buttonstyle attributes

Categories

(Toolkit :: UI Widgets, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
      No description provided.
Attachment #424473 - Flags: review?(neil)
Comment on attachment 424473 [details] [diff] [review]
patch

>-toolbarbutton:hover:active[buttonstyle="text"],
>-toolbarbutton[open="true"][buttonstyle="text"] {
Confusingly buttonstyle has become mode; toolbarmode became iconsize. Unfortunately this is in pinstripe so I can't tell whether it is correct to delete this or whether it should have switched to using mode instead. Given that the rule was never used, it seems unlikely, but I'd appreciate it if you could get a second opinion. r=me for toolbarbutton.xml either way.
Attachment #424473 - Flags: review?(neil) → review+
Attachment #424473 - Flags: review?(rflint)
Comment on attachment 424473 [details] [diff] [review]
patch

Anyone seeking blue text in pinstripe is probably already doing the styling themselves. r=me.
Attachment #424473 - Flags: review?(rflint) → review+
http://hg.mozilla.org/mozilla-central/rev/ca5c79a77bd0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: