543318 - Regular expression converts '-' (minus) into hex code 0x01 (start of heading)

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[djmaze]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.6) Gecko/20091216 Fedora/3.5.6-1.fc11 Firefox/3.5.6
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.6) Gecko/20091216 Fedora/3.5.6-1.fc11 Firefox/3.5.6

When running a regular expression to match certain characters to escape them.
It converts the minus sign into hex code 0x01


Reproducible: Always

Steps to Reproduce:
format = '%d-%m';
alert(format.replace(/([\-\.\(\)])/g,'\\\1'));
Actual Results:  
%d\%m

Expected Results:  
%d\-%m

Comment 1

[Brendan Eich [:brendan]]

You want $1 in the replacement string, not \1:

js> alert=print
function print() {[native code]}
js> format = '%d-%m';
"%d-%m"
js> alert(format.replace(/([\-\.\(\)])/g,'\\\1'));
%d\%m
js> RegExp.$1
"-"
js> RegExp.$2
""
js> RegExp.$_
"%d-%m"
js> alert(format.replace(/([\-\.\(\)])/g,'\\$1'));
%d\-%m

/be