Remove repetitions (the, of) from Help

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Help Documentation
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

({fixed-seamonkey2.0.4})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 424496 [details] [diff] [review]
patch

I found that some words like "the" or "of" are falsely repeated in Help. This should be corrected.

I included two occurrences of "take affect" -> "take effect" that I originally wanted to fix in bug 459578. We may as well do it here, no?
(Assignee)

Updated

7 years ago
Assignee: nobody → jh
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Attachment #424496 - Attachment is patch: true
Attachment #424496 - Attachment mime type: application/octet-stream → text/plain
Attachment #424496 - Flags: review?(iann_bugzilla)

Comment 1

7 years ago
Comment on attachment 424496 [details] [diff] [review]
patch

Have you checked where the repetitions maybe at the end of one line and the start of another?
Could you also raise separate bugs for the same issue in suite/ and mailnews/ code (and other code areas if you are feeling generous). e.g. http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/mailnews/localMsgs.properties#227 http://mxr.mozilla.org/comm-central/source/suite/themes/classic/communicator/tasksOverlay.css#39 and http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgSendPart.cpp#775
Attachment #424496 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 2

7 years ago
Created attachment 424665 [details] [diff] [review]
patch v1a [Checkin: comments 5 + 7]

(In reply to comment #1)
> (From update of attachment 424496 [details] [diff] [review])
> Have you checked where the repetitions maybe at the end of one line and the
> start of another?

No but it came to my mind in the meantime. Found another one. :-) Since it's an obvious one I'll just carry over your r+.

This is what I used (certainly not perfect):
for f in *.*; do tr '\r\n' '  ' < $f | grep -iE "the[\t ]*[\t ]the[\t ]*[\t ]";
echo $f; done

> Could you also raise separate bugs for the same issue in suite/ and mailnews/
> code (and other code areas if you are feeling generous). e.g.
> http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/chrome/mailnews/localMsgs.properties#227

Filed Bug 543571 for that and two similar occurrences.

> http://mxr.mozilla.org/comm-central/source/suite/themes/classic/communicator/tasksOverlay.css#39
> http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgSendPart.cpp#775

Correcting inline comments is overkill, don't you think? ;-)
Attachment #424496 - Attachment is obsolete: true
Attachment #424665 - Flags: review+

Comment 3

7 years ago
(In reply to comment #2)
> 
> This is what I used (certainly not perfect):
> for f in *.*; do tr '\r\n' '  ' < $f | grep -iE "the[\t ]*[\t ]the[\t ]*[\t ]";
> echo $f; done
Have you done similar for of of and take affect/effect?

> > http://mxr.mozilla.org/comm-central/source/suite/themes/classic/communicator/tasksOverlay.css#39
> > http://mxr.mozilla.org/comm-central/source/mailnews/compose/src/nsMsgSendPart.cpp#775
> 
> Correcting inline comments is overkill, don't you think? ;-)
Probably.
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> (In reply to comment #2)
> > 
> > This is what I used (certainly not perfect):
> > for f in *.*; do tr '\r\n' '  ' < $f | grep -iE "the[\t ]*[\t ]the[\t ]*[\t ]";
> > echo $f; done
> Have you done similar for of of and take affect/effect?

Yes, no matches found. Note that the command only finds possible cases so even if a match had been found it would have required further checking.
(Assignee)

Comment 5

7 years ago
Comment on attachment 424665 [details] [diff] [review]
patch v1a [Checkin: comments 5 + 7]

http://hg.mozilla.org/comm-central/rev/1be1bb004b5d
Attachment #424665 - Attachment description: patch v1a → patch v1a [Checkin: comment 5]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
(Assignee)

Comment 6

7 years ago
Comment on attachment 424665 [details] [diff] [review]
patch v1a [Checkin: comments 5 + 7]

Requesting branch approval.

[KaiRo]	InvisibleSmiley: help changes are allowed, as long as the list of the help files stays the same

Even if these are not critical fixes they may ease back-porting patches to the branch.
Attachment #424665 - Flags: approval-seamonkey2.0.4?

Updated

7 years ago
Attachment #424665 - Flags: approval-seamonkey2.0.4? → approval-seamonkey2.0.4+
(Assignee)

Comment 7

7 years ago
Comment on attachment 424665 [details] [diff] [review]
patch v1a [Checkin: comments 5 + 7]

http://hg.mozilla.org/releases/comm-1.9.1/rev/78649423e5b7
Attachment #424665 - Attachment description: patch v1a [Checkin: comment 5] → patch v1a [Checkin: comments 5 + 7]
(Assignee)

Updated

7 years ago
Keywords: fixed-seamonkey2.0.4
You need to log in before you can comment on or make changes to this bug.