543384 - Multi-line assertion that makes jsfunfuzz sad

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Multi-line assertions like the one in bug 543161 are hard for jsfunfuzz to ignore.

The python script that runs jsfunfuzz looks at the output one line at a time. It recognizes anything that starts with "Assertion failure:" as an assertion, but treats it as a known bug if it also matches one of the longer strings in js-known/mozilla-central/assertions.txt.  When an assertion message starts with a line break, there's nothing safe to match on and ignore.

I guess you could put the extra info in non-assertion output just before the assertion failure.  Alternatively, you could put the first line of the message on the first line (don't start with a line break).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: patch

This patch makes the assertion messages pithier -- including removing the debugging advice which was probably overkill -- and puts them all on one line.

Comment 2

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/42624af80954

Comment 3

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/2ea76f3022f8

Comment 4

[Steven Johnson]

http://hg.mozilla.org/tamarin-redux/rev/ce413b266124

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/2ea76f3022f8