543501 - Refactor Mozmill, Mozrunner, and JsBridge to use --addon instead of --plugin

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

We would have to refactor all three applications so we call out extensions instead of plugins. We already got feedback twice that this is a confusing naming at the moment.

If someone has time to work on it, we would appreciate the work.

Comment 1

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Part 1 which only changes the command line option:
http://github.com/whimboo/mozrunner/commit/88171f2145f6ff24e8f00bf025e94e7b70a9ccad

There are a couple of other instances for "plugins" we will have to update before marking this bug as fixed.

Comment 2

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Patch 1 has been merged. Mikeal, can we please create a new pyPI version for Mozrunner?

Comment 3

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

(In reply to comment #2)
> Patch 1 has been merged. Mikeal, can we please create a new pyPI version for
> Mozrunner?

Mikeal, please push a new version ASAP! The testday is today and we really need that fixed. Thanks!

Comment 4

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Part 2 has been finished and pull requests have been sent:
http://github.com/whimboo/mozrunner/commit/726b8a0e83aaa546526f2d0b4a469af9600dbca5
http://github.com/whimboo/mozmill/commit/f2df36c7273f9ca0db4de2f332fe0982155b5867
http://github.com/whimboo/jsbridge/commit/7d6c67c9056d6bd95e5d53ebbcefe2272d6e41c9

Comment 5

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Everything has been pushed by Mikeal.

Comment 6

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Verified fixed with release candidates for Mozmill, Jsbridge, and Mozrunner.