543554 - [Autoconfiguration] Add sympatico.ca domains

Status: RESOLVED FIXED

(Webtools :: ISPDB Server, defect)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Attachment: Diff for XML file sympatico.ca

please append attached xml diff to https://live.mozillamessaging.com/autoconfig/ 

Reproducible: Always

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 424656 [details] [diff] [review]
Diff for XML file sympatico.ca 

>Index: sympatico.ca
>@@ -0,0 +1,29 @@
>+<clientConfig>
>+    <emailProvider id="sympatico.ca">
>+      <domain>sympatico.ca/domain>
The previous line should have a "<" before the "/domain>".

And I don't have an account to test it with, so could you make sure that those settings work, Roland?

Aside from that, it passes all the sanity checks, and seems secure, so I'll give it the first r+.

Later,
Blake.

Comment 2

[Matt]

Attachment: added the < requested long in the past

This is my first try at this. I hope I have a vague idea how it works

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to Matt from comment #2)
> Created attachment 565909 [details] [diff] [review] [diff] [details] [review]
> added the < requested long in the past
> 
> This is my first try at this. I hope I have a vague idea how it works

Drive by comment, I don't see any url with documentation - but probably sympatico doesn't have one.

Comment 4

[Matt]

(In reply to Ludovic Hirlimann [:Usul] from comment #3)
>
> Drive by comment, I don't see any url with documentation - but probably
> sympatico doesn't have one.

http://internet.bell.ca/index.cfm?method=content.view&category_id=585&content_id=12767

Is that supposed to go in bug URL, or here

Comment 5

[Ludovic Hirlimann [:Usul]]

In the file.

Comment 6

[Matt]

Attachment: New patch

After fumbling around on live mozillamessageing.com I think I have figured out the correct format to include the documentation URL.

Comment 7

[Philippe M. Chiasson (:gozer)]

Comment on attachment 586937 [details] [diff] [review]
New patch

Looks good and verified.

Comment 8

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

yeah it looks good Matt, thanks! note that i don't have sympatico and haven't been able to test this. any canadians out there who have sympatico who want to verify this config is correct?

Comment 9

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 586937 [details] [diff] [review]
New patch

& is an invalid character in XML and it should be &

Fixed and committed in r100051 & r100053