54367 - 3-pane Focus ring is still slow

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Alec Flett]

FocusRingUpdate_Mail() takes .2 to .3 seconds on my machine even when the focus
doesn't change, which is really bad.

I hacked the JS and make it alot faster (0.001 seconds), patch on the way.

Comment 1

[Alec Flett]

nominating for rtm
putterman has reviewed this patch. It does not change the functionality of the
focus ring in any way, it just makes it faster by fixing up comparisons in
loops, simplifying logic, etc.

Comment 2

[Alec Flett]

Attachment: speed up the focus ring

Comment 3

[andreww]

I second that nomination - this is an easy way to get a boost in mailnews 
performance.

Comment 4

[selmer (gone)]

rtm+, looks like a 200x or 300x improvement and we think that is a second or 
more on the target machine.  The risk is low, worst case is focus rings fail to 
show up.

Have r=putterman, looking for sr=mscott

Comment 5

[Scott MacGregor]

sr=mscott

Comment 6

[Phil Peterson]

PDT marking rtm++

Comment 7

[Alec Flett]

ok, fix went in (minus the timing stuff of course!)

Comment 8

[Alec Flett]

oops, actually mark it fixed.

Comment 9

[Daniel Bratell]

Don't we want this for the trunk too? I only saw a checkin on the branch, but
I'm sure we want it fast even after Netscape's release of NS6.

Comment 10

[Alec Flett]

oh thanks, I almost forgot! I'll check in there today.

Comment 11

[Alec Flett]

fix finally checked into the trunk

Comment 12

[Alec Flett]

oops, actually marking fixed.

Comment 13

[Ninoschka Baca]

Branch build 2000-10-06-10MN6: Linux 6.0
Fixed.

Marking 'vtrunk' so this is checked on the trunk.

Comment 14

[varada]

marking vbranch.

Comment 15

[Asa Dotzler [:asa]]

I'm confused here.  This was verified by nbaca on the branch on 10/9.  the
vtrunk keyword was added so that it would show up as needing verification on the
Trunk.  Then the vbranch keyword was added by varada (which implies that this
has been Verified on the trunk and needs verification on the branch).  I'm
assuming varada's keyword was in error since it wasn't accompanied by build id
and platforms tested.  Removing vbranch keyword.  BTW, how does one verify that
this is fixed?

Comment 16

[Alec Flett]

it's a code change, and I think we should just mark it verified... the problem
was that clicking on a message took an absurdly long time because we were
updating focus styles.

Comment 17

[Asa Dotzler [:asa]]

OK, removing vtrunk keyword.  This one is done :)