AbcEnv::~AbcEnv touchs AvmCore which could be gone

VERIFIED FIXED in flash10.1

Status

Tamarin
Garbage Collection (mmGC)
P1
blocker
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Tommy Reilly, Assigned: Tommy Reilly)

Tracking

unspecified
flash10.1
x86
Mac OS X

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Yes the player will delete the AvmCore and the GC will finalize the AbcEnv later, chaos ensues.
(Assignee)

Updated

8 years ago
Assignee: nobody → treilly
Severity: normal → blocker
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → flash10.1
(Assignee)

Comment 1

8 years ago
Created attachment 424795 [details] [diff] [review]
prevent said touching
Attachment #424795 - Flags: superreview?(edwsmith)
Attachment #424795 - Flags: review?(stejohns)

Comment 2

8 years ago
Comment on attachment 424795 [details] [diff] [review]
prevent said touching

nice find. bad injection on my part.

r+ on the condition that we add a comment indicating that m_core can be stale and referencing this bug id.
Attachment #424795 - Flags: review?(stejohns) → review+
(Assignee)

Comment 3

8 years ago
do we typically put bug id's in the code?   I'd prefer to let the hg message contain the bug id

Comment 4

8 years ago
protocol for "fixme" comments is:
// fixme: bug ####: description

(or todo, etc).  elaboration and status can go in the bug (or code, if appropriate).  duplication in the hg comments is fine too.

Comment 5

8 years ago
Comment on attachment 424795 [details] [diff] [review]
prevent said touching

The only way this is safe is if core being null implies caches don't need flushing.  i think that's valid, second opinion?
Attachment #424795 - Flags: superreview?(edwsmith) → superreview+

Comment 6

8 years ago
(In reply to comment #5)
> (From update of attachment 424795 [details] [diff] [review])
> The only way this is safe is if core being null implies caches don't need
> flushing.  i think that's valid, second opinion?

correct
(Assignee)

Comment 7

8 years ago
tr: 3710
tr-argo: 3646
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 8

8 years ago
Engineering work item.  Marking verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.