543763 - AbcEnv::~AbcEnv touchs AvmCore which could be gone

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P1)

Description

[Tommy Reilly]

Yes the player will delete the AvmCore and the GC will finalize the AbcEnv later, chaos ensues.

Comment 1

[Tommy Reilly]

Attachment: prevent said touching

Comment 2

[Steven Johnson]

Comment on attachment 424795 [details] [diff] [review]
prevent said touching

nice find. bad injection on my part.

r+ on the condition that we add a comment indicating that m_core can be stale and referencing this bug id.

Comment 3

[Tommy Reilly]

do we typically put bug id's in the code?   I'd prefer to let the hg message contain the bug id

Comment 4

[Edwin Smith]

protocol for "fixme" comments is:
// fixme: bug ####: description

(or todo, etc).  elaboration and status can go in the bug (or code, if appropriate).  duplication in the hg comments is fine too.

Comment 5

[Edwin Smith]

Comment on attachment 424795 [details] [diff] [review]
prevent said touching

The only way this is safe is if core being null implies caches don't need flushing.  i think that's valid, second opinion?

Comment 6

[Steven Johnson]

(In reply to comment #5)
> (From update of attachment 424795 [details] [diff] [review])
> The only way this is safe is if core being null implies caches don't need
> flushing.  i think that's valid, second opinion?

correct

Comment 7

[Tommy Reilly]

tr: 3710
tr-argo: 3646

Comment 8

[Chris Peyer]

Engineering work item.  Marking verified fixed.