Closed
Bug 543766
Opened 14 years ago
Closed 13 years ago
Disabling 3rd Party Cookies breaks microsummary generation
Categories
(Firefox Graveyard :: Microsummaries, defect)
Firefox Graveyard
Microsummaries
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sdwilsh, Unassigned)
Details
(Keywords: dogfood, privacy, Whiteboard: [microsummaries-feature-removal])
Attachments
(1 file)
1.05 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
I use microsummaries for some bugzilla queries, and if you disable third party cookies, they no longer work.
Flags: in-testsuite?
Reporter | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 2•14 years ago
|
||
Whoops, not a duplicate.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Reporter | ||
Comment 3•14 years ago
|
||
In nsMicrosummaryService.js, the load function just needs to QI request.channel to nsIHttpChannelInternal, and set forceAllowThirdPartyCookie.
Reporter | ||
Comment 4•14 years ago
|
||
Rwar. I want to disable third party cookies, and this is the only reason why I cannot.
Assignee: nobody → sdwilsh
Status: REOPENED → ASSIGNED
Reporter | ||
Comment 5•14 years ago
|
||
We can't really unit test this in an automated way as far as I can tell.
Attachment #441400 -
Flags: review?(dietrich)
Reporter | ||
Updated•14 years ago
|
Flags: in-testsuite?
Flags: in-testsuite-
Flags: in-litmus?
Comment 6•14 years ago
|
||
Given that the user specifically disabled 3rd party cookies, why is it OK for us to circumvent that here?
Reporter | ||
Comment 7•14 years ago
|
||
Because we are going to the first party site. Chrome is considered a third party, but chrome is privileged. We are not loading arbitrary content, but rather content from the site that has the cookie.
Comment 8•14 years ago
|
||
Comment on attachment 441400 [details] [diff] [review] v1.0 r=me. seems like this should be testable, using the local server?
Attachment #441400 -
Flags: review?(dietrich) → review+
Reporter | ||
Updated•13 years ago
|
Assignee: sdwilsh → nobody
Status: ASSIGNED → NEW
Whiteboard: [needs test][good first bug]
Target Milestone: Firefox 3.7a5 → ---
Comment 9•13 years ago
|
||
- BUGSPAM - Wontfixing all Microsummaries bugs, since the feature has been removed from the core product and previous versions won't get further fixes for it. If interested in supporting Microsummaries in your add-on, you're free to use our old microsummaries code and to search all previously open bugs by looking for [microsummaries-feature-removal] in the status whiteboard field.
Status: NEW → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → WONTFIX
Whiteboard: [needs test][good first bug] → [microsummaries-feature-removal]
Assignee | ||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•