543771 - textbox on panel with noautohide="true" doesn't work

Status: RESOLVED DUPLICATE of bug 526941

(Core :: XUL, defect)

Description

[Kazuho Okui]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6

xul:textbox on xul:panel with noautohide="true" doesn't work at all. I can't start typing, even can't focus to it.

Reproducible: Always

Steps to Reproduce:
1. Create xul:panel with noautohide="true"
2. Add xul:textbox on the panel
3. Open panel
Actual Results:  
textbox doesn't work. Can't focus, can't enter text.


This issue happens only on Firefox 3.6 on Linux. Same code works fine on Firefox 3.0, and 3.5, on Windows and on Mac OS X. If panel doesn't have noautohide="true" option, textbox works appropriately.

Comment 1

[Kazuho Okui]

Attachment: code that reproduces this issue

Sample code that reproduces this issue.

Comment 3

[Kazuho Okui]

I don't think this bug is duplicated as bug 385609. The code works fine on Firefox 3.5 on Liinux, and all version of Fx on Mac / Window. It's definitely some kind of regression from Fx 3.5 to 3.6 on Linux platform. bug 385609 can reproduce on Mac and Windows, reported 3 years ago. Phenomenon looks same, but causes might be different IMO.

Comment 4

[Neil Deakin]

Attachment: fix

This patch:
 - changes the direction to always be forward for focusing-to-caret mode
 - when the caret is not set at any location, or is at the root, don't call GetFocusInSelection but return early so that we don't continue looking for a node to focus.

Comment 5

[Neil Deakin]

Comment on attachment 425492 [details] [diff] [review]
fix

oops, wrong bug.

Comment 6

[haipeng Du]

 I got the same problem. Can not type anything inside textbox which is inside panel. It has only problem under linux. The same codes works on windows.
<panel noautohide="true">
<textbox />
</panel>
The same code works before I upgrade to 3.6.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I was about to file this as a new bug when I saw this bug. It's exactly what I'm experiencing.

I maintain a Firefox extension called RTSE, and part of it is a text editor created in an XUL panel that overlays the browser. It has the noautohide attribute set to true.

A while back when I was using Ubuntu as my primary operating system, it worked fine. (This was back around Firefox 3/3.5) Since then, I've switched to Windows 7 as my primary OS, and the text editor has always worked fine since then in Windows, so I didn't notice that it had stopped working until one of the addon's users pointed out that it stopped working sometime last year on Linux.

So after a long session last night of me trying to track down when it actually stopped working in Firefox, I've narrowed it down to a single nightly build's changes. The June 10 mozilla-central nightly works just fine, while the June 11 moz-central nightly has an inoperable textbox. (Well, you can get text into the textbox by pasting it in through the context menu, but you can't type directly.)

Looking through the pushlog around that time ( http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=june+09%2C+2009&enddate=june+12%2C+2009 ), the most obvious change made was for bug 178324, http://hg.mozilla.org/mozilla-central/rev/cabb8925dcd3 .

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #7)
That's June 10 and June 11, 2009, just to clarify.
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/06/2009-06-10-03-mozilla-central/
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/06/2009-06-11-03-mozilla-central/

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #7)
As a workaround for this bug that I'm hitting in my extension, I changed "noautohide" to false for Linux installations via an overlay. This kinda fixes the problem (users are at least able to type in the textbox), but it disappears anytime the user clicks outside of the editor, or closes a dialog launched from the editor, so I'd rather not have to leave it like this.

One of the users reported that the workaround didn't work when using the XFCE and LXDE display environments. I haven't confirmed this (I tend to stick with Gnome when I do stuff in Linux-land), so I don't know if it's just a problem with that one user's machine.