Assertion misplaced after code additions above a disconnected #ifdefed else branch

RESOLVED FIXED

Status

()

--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
In nsHTMLDocument.cpp, the code 

#ifdef DEBUG
  else {
    NS_ASSERTION(mIsRegularHTML,
      "Hey, someone forgot to reset mIsRegularHTML!!!");
  }
#endif

has gotten disconnected from the if it used to belong to--causing bogus assertions.
(Assignee)

Comment 1

9 years ago
Created attachment 424944 [details] [diff] [review]
Relocate the disconnected else branch to where it belongs
Attachment #424944 - Flags: review?(jfkthame)
(Assignee)

Comment 2

9 years ago
Comment on attachment 424944 [details] [diff] [review]
Relocate the disconnected else branch to where it belongs

FWIW, the else branch got disconnected from its if months ago, but yesterday's patch made it worse.
Attachment #424944 - Flags: review?(jfkthame) → review?(bzbarsky)
Comment on attachment 424944 [details] [diff] [review]
Relocate the disconnected else branch to where it belongs

Looks good.
Attachment #424944 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/b53308cf5495
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.