Closed
Bug 543930
Opened 15 years ago
Closed 15 years ago
Assertion misplaced after code additions above a disconnected #ifdefed else branch
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
Attachments
(1 file)
|
1021 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
In nsHTMLDocument.cpp, the code
#ifdef DEBUG
else {
NS_ASSERTION(mIsRegularHTML,
"Hey, someone forgot to reset mIsRegularHTML!!!");
}
#endif
has gotten disconnected from the if it used to belong to--causing bogus assertions.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #424944 -
Flags: review?(jfkthame)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 424944 [details] [diff] [review]
Relocate the disconnected else branch to where it belongs
FWIW, the else branch got disconnected from its if months ago, but yesterday's patch made it worse.
Attachment #424944 -
Flags: review?(jfkthame) → review?(bzbarsky)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 424944 [details] [diff] [review]
Relocate the disconnected else branch to where it belongs
Looks good.
Attachment #424944 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•