StackGrowDirection is wrong on Solaris x86 release build

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
RESOLVED WONTFIX
8 years ago
8 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
jscpucfg is now a c++ program. The old trick for Sun Studio C compiler fails.
//sigh
(Assignee)

Comment 1

8 years ago
Created attachment 424959 [details] [diff] [review]
patch

__SUNPRO_C is C compiler, __SUNPRO_CC is C++ compiler
But Sun C++ doesn't support #pragma no_inline.
We can use -xinline=no%function in command line, or lower the optimization level for this file.

Use extern "C", so that I don't have to use mangled name for it.

Another minor change not related to this bug:
Do not use lock_sparcv8plus.il for jslock.o on x86. I did a mistake in my previous fix.
However it is harmless.
Assignee: general → ginn.chen
Status: NEW → ASSIGNED
Attachment #424959 - Flags: review?(jim)

Comment 2

8 years ago
Ginn --- does the patch attached to bug 552500 work for you here?
(Assignee)

Comment 3

8 years ago
Yes, I think so.

Thanks!

Comment 4

8 years ago
Okay.  I've asked jorendorff to review bug 552500.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX

Updated

8 years ago
Attachment #424959 - Flags: review?(jim)
You need to log in before you can comment on or make changes to this bug.