Closed Bug 543986 Opened 16 years ago Closed 16 years ago

False positive in 012throwables.t, 'object_does_not_exist' is still in use

Categories

(Bugzilla :: Testing Suite, defect)

3.5.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

Due to the change in Object.pm in bug 514970, t/012throwables.t thinks that ... ok 177 - --WARNING template/en/default/global/user-error.html.tmpl has 1 unused error tag(s): # user error tag 'object_does_not_exist' is defined at line(s) (1258) but is not used anywhere but this tag is used, in Object.pm.
Flags: blocking3.6+
Attached patch patch, v1 — — Splinter Review
Easiest way to fix the problem, rather than hacking 012throwables.t with some exception list.
Assignee: testing → LpSolit
Status: NEW → ASSIGNED
Attachment #425456 - Flags: review?(mkanat)
Comment on attachment 425456 [details] [diff] [review] patch, v1 I like it. :-) I was considering putting in a comment to fool the test, but this is probably even better, because it's real live code.
Attachment #425456 - Flags: review?(mkanat) → review+
Flags: approval3.6+
Flags: approval+
(In reply to comment #2) > I like it. :-) I was considering putting in a comment to fool the test Comments are skipped by 012throwables.t, so this wouldn't work anyway. I thought about that too. :)
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Object.pm Committed revision 6961. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/ modified Bugzilla/Object.pm Committed revision 6956.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: