Closed
Bug 543986
Opened 16 years ago
Closed 16 years ago
False positive in 012throwables.t, 'object_does_not_exist' is still in use
Categories
(Bugzilla :: Testing Suite, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
903 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Due to the change in Object.pm in bug 514970, t/012throwables.t thinks that ...
ok 177 - --WARNING template/en/default/global/user-error.html.tmpl has 1 unused error tag(s):
# user error tag 'object_does_not_exist' is defined at line(s) (1258) but is not used anywhere
but this tag is used, in Object.pm.
Flags: blocking3.6+
| Assignee | ||
Comment 1•16 years ago
|
||
Easiest way to fix the problem, rather than hacking 012throwables.t with some exception list.
Comment 2•16 years ago
|
||
Comment on attachment 425456 [details] [diff] [review]
patch, v1
I like it. :-) I was considering putting in a comment to fool the test, but this is probably even better, because it's real live code.
Attachment #425456 -
Flags: review?(mkanat) → review+
Updated•16 years ago
|
Flags: approval3.6+
Flags: approval+
| Assignee | ||
Comment 3•16 years ago
|
||
(In reply to comment #2)
> I like it. :-) I was considering putting in a comment to fool the test
Comments are skipped by 012throwables.t, so this wouldn't work anyway. I thought about that too. :)
| Assignee | ||
Comment 4•16 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Object.pm
Committed revision 6961.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Object.pm
Committed revision 6956.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•