544017 - Fix DEBUG_A11Y compile path and move TestChildCache to DEBUG

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: easy fix

Comment 1

[alexander :surkov (:asurkov)]

Comment on attachment 425007 [details] [diff] [review]
easy fix

change the uuid and make this under DEBUG not DEBUG_A11Y.

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 425007 [details] [diff] [review]
easy fix

I'd like to look at next patch

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #1)
> (From update of attachment 425007 [details] [diff] [review])
> change the uuid and make this under DEBUG not DEBUG_A11Y.

Did you mean the component ID?

The uuid defines the interface nsIAccessible which hasn't changed. Enn tells me we never need to change the component ID (NS_ACCESSIBLE_IMPL_CID).

I'm actually unsure how the nsAccessible component ID is used. (Maybe I slept wrong last night)

I really don't want to use DEBUG, because I would like to keep the information separate. I'd like to be able to make -B -CXXFLAGS="-DDEBUG_A11Y" because "-DDEBUG" would pick up all kinds of spew/noise.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: impl TestChildCache for regular DEBUG compile path.

Better I think :)

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: called now under DEBUG as well

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Landed on trunk as http://hg.mozilla.org/mozilla-central/rev/d0d115297349