Closed Bug 544158 Opened 16 years ago Closed 16 years ago

fix incorrect type usage for NPP_SetValue NPNVprivateModeBool

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
PowerPC
Linux
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(status1.9.2 .9-fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- .9-fixed

People

(Reporter: karlt, Assigned: jaas)

References

Details

Attachments

(2 files, 3 obsolete files)

fix v1.0
1.88 KB, patch
karlt
: review+
Details | Diff | Splinter Review
fix v1.1 for 1.9.2
1.88 KB, patch
karlt
: review+
christian
: approval1.9.2.9+
Details | Diff | Splinter Review
The proposal for NPNVprivateModeBool in bug 468877 comment 8 suggested that NPP_SetValue use a NULL or non-NULL pointer, but the implementation ended up as a pointer to PRBool. Bug 540775 changed this to pointer to long. This is minor as it only affects all those big-endian LP64 systems out there.
Hardware: x86 → PowerPC
Attached patch patch (obsolete) — — Splinter Review
Removed Flash from the comment too, as flash doesn't have setvalue. Josh, do you know if any plugins are using this, is it too late to change to NULL/non-NULL pointer?
Attachment #425131 - Flags: review?(joshmoz)
Attached patch patch (obsolete) — — Splinter Review
Missed one.
Attachment #425131 - Attachment is obsolete: true
Attachment #425132 - Flags: review?(joshmoz)
Attachment #425131 - Flags: review?(joshmoz)
I talked to Karl on irc, we decided to make our code conform to the spec: https://wiki.mozilla.org/Plugins:PrivateMode Thanks for catching this Karl!
Summary: make NPP_SetValue NPNVprivateModeBool use *PRBool → use correct type for NPP_SetValue NPNVprivateModeBool in all cases
Attachment #425132 - Attachment is obsolete: true
Attachment #425132 - Flags: review?(joshmoz)
Assignee: karlt → joshmoz
For future reference, it looks like WebKit follows the spec properly: http://trac.webkit.org/browser/trunk/WebCore/plugins/PluginView.cpp
Attached patch fix v1.0 — — Splinter Review
Comment on attachment 432484 [details] [diff] [review] fix v1.0 Thank you.
Attachment #432484 - Flags: review+
Summary: use correct type for NPP_SetValue NPNVprivateModeBool in all cases → fix incorrect type usage for NPP_SetValue NPNVprivateModeBool
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/a20352e6761d
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attached patch fix v1.0 for 1.9.2 (obsolete) — — Splinter Review
Attachment #433085 - Flags: approval1.9.2.3?
Attachment #433085 - Flags: approval1.9.2.4? → approval1.9.2.8?
Comment on attachment 433085 [details] [diff] [review] fix v1.0 for 1.9.2 a=LegNeato for 1.9.2.9
Attachment #433085 - Flags: approval1.9.2.9? → approval1.9.2.9+
The patch for 1.9.2 has gone out of date since OOPP landed on the 1.9.2 branch.
Attachment #433085 - Attachment is obsolete: true
Attachment #462309 - Flags: review?(karlt)
Attachment #462309 - Flags: review?(karlt) → review+
Comment on attachment 462309 [details] [diff] [review] fix v1.1 for 1.9.2 Re-requesting 1.9.2 approval just to be safe.
Attachment #462309 - Flags: approval1.9.2.9?
Comment on attachment 462309 [details] [diff] [review] fix v1.1 for 1.9.2 a=LegNeato for 1.9.2.9
Attachment #462309 - Flags: approval1.9.2.9? → approval1.9.2.9+
Attachment #433085 - Flags: approval1.9.2.9+ → approval1.9.2.9-
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: