544192 - Qt Xembed version required for IPC browser content embedding

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: XEmbed Qt container

Electrolisys branch Qt version for nsFrameLoader, TabChild..

Comment 1

[Benjamin Smedberg]

Comment on attachment 425170 [details] [diff] [review]
XEmbed Qt container

redirecting reviews... I don't know who our Qt reviewer-of-record is, but it's definitely not me.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 425170 [details] [diff] [review]
XEmbed Qt container

qt stuff looks fine.  other nits:

just use 
NS_ENSURE_TRUE(mRemoteSocket, PR_FALSE);

instead of

+  if (!mRemoteSocket) {
+    NS_ERROR("Socket creation failed");
+    return false;
+  }

and

use 

NS_ENSURE_TRUE(win, PR_TRUE);

instead of

+    if (!win) {
+        NS_ERROR("Cannot create QX11EmbedWidget");
+        return true;
+    }

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 425170 [details] [diff] [review]
XEmbed Qt container

Seems fine to me.

Comment 4

[Oleg Romashin (:romaxa)]

Pushed with fixes to:
http://hg.mozilla.org/projects/electrolysis/rev/367b795dfbcf