Closed
Bug 544299
Opened 16 years ago
Closed 13 years ago
Change Selenium PHP tests to work with Hudson
Categories
(support.mozilla.org :: General, defect)
support.mozilla.org
General
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: laura, Unassigned)
Details
Attachments
(2 files, 1 obsolete file)
|
30.05 KB,
patch
|
vish_moz
:
review+
|
Details | Diff | Splinter Review |
|
10.55 KB,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
We need a config file, basically. Patch coming in comment #1
| Reporter | ||
Updated•16 years ago
|
Assignee: nobody → laura
| Reporter | ||
Comment 1•16 years ago
|
||
I followed what clouserw did for moz.com but I'd just like you to check that I haven't broken anything...
Attachment #425248 -
Flags: review?
| Reporter | ||
Updated•16 years ago
|
Attachment #425248 -
Flags: review? → review?(stephen.donner)
Comment 2•16 years ago
|
||
Laura,
Please make the following changes:
1. leave the line
$this->selenium->open("http://support:stage@support-stage.mozilla.org");
as it is in TC_rewrites.php
2. change
if (!defined('SERVER_NAME'))
define('SERVER_NAME', 'support:stage@support-stage.mozilla.org');
to
if (!defined('SERVER_NAME'))
define('SERVER_NAME', 'support-stage.mozilla.org');
3. Also, the test cases files will have to be renamed. Just prepend the names with
test_
| Reporter | ||
Comment 3•16 years ago
|
||
Attachment #425248 -
Attachment is obsolete: true
Attachment #425485 -
Flags: review?(vish.mozilla)
Attachment #425248 -
Flags: review?(stephen.donner)
Comment 4•16 years ago
|
||
The changes look good.
Comment 5•16 years ago
|
||
(In reply to comment #4)
> The changes look good.
Vishal, please click on "Details" for Laura's patch and mark it as r+; thanks!
Comment 6•16 years ago
|
||
Comment on attachment 425485 [details] [diff] [review]
patch with vish_moz changes
marking it as 'Reviewed'.
Attachment #425485 -
Flags: review?(vish.mozilla) → review+
| Reporter | ||
Comment 7•16 years ago
|
||
in r61845
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 8•16 years ago
|
||
Vishal, are you able to verify this?
| Reporter | ||
Comment 9•16 years ago
|
||
Stephen: I don't think he'll be able to...in fact I need to reopen this
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•16 years ago
|
||
Made changes to the rewrite script.
1. renamed config.php to configuration.php
2. removed moz_testCase inheritance
3. added code to varify as=u parameter in redirect URL's
Comment 11•16 years ago
|
||
Laura, sorry, I have already checked-in the fix at http://viewvc.svn.mozilla.org/vc/projects/sumo/tests/frontend/php_tests/test_TC_rewrites.php?view=log
Attachment #429017 -
Flags: review?(laura)
| Reporter | ||
Updated•16 years ago
|
Attachment #429017 -
Flags: review?(laura) → review+
| Reporter | ||
Updated•16 years ago
|
Assignee: laura → nobody
Comment 12•13 years ago
|
||
I totally don't understand what this is about, but assuming this is about testing php code in some way, I'm closing this bug, since we are on python now.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 13 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•