544333 - [OS/2] update include path for resource compiler

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.3a1pre) Gecko/20100204 Minefield/3.7a1pre
Build Identifier: 

Since firefox is build libxul enabled by default and seamonkey is a shared build and thunderbird was built on top of mozilla-1.9.1, I've got aware of this bug only yesterday when I tried to build thunderbird from c-c on top of m-c for the first time. The header directory in dist was flattened. We have to adjust the include path for the resource compiler for static builds It fails to find dist/include/widget

Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: for m-c [Checkin: Comment 7]

Comment 2

[Walter Meinl]

Attachment: for c-c tb sm sb [Checkin: Comment 6]

Comment 3

[Dave Yeo]

I don't have permission to r+ as both attachments deserve.
I never came across this bug as I usually build Thunderbird etc shared.

Comment 4

[Walter Meinl]

Comment on attachment 425274 [details] [diff] [review]
for c-c tb sm sb
[Checkin: Comment 6]

Set to r+ after approval from Dave in comment #3

Comment 5

[Walter Meinl]

Comment on attachment 425273 [details] [diff] [review]
for m-c
[Checkin: Comment 7]

Set to r+ after approval from Dave in comment #3

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 425274 [details] [diff] [review]
for c-c tb sm sb
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/27334ef4b0be

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 425273 [details] [diff] [review]
for m-c
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/cf63181a4e51

Comment 8

[Walter Meinl]

(In reply to comment #7)
> (From update of attachment 425273 [details] [diff] [review])
> 
Serge, for getting this in mozilla-1.9.2 you think I have to ask for approval from drivers? In principle, we have a+ for OS/2-only patches for all trees as they are NPOTB. However, though only in an ifdef XP_OS2 section this is in cross-platform file. On the other hand I don't want to bother drivers with such trivial patches that won't interfere with tier_1 platforms.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> we have a+ for OS/2-only patches for all trees as they are NPOTB.

I assume that's enough.