544373 - Going back to older checkins broken outside of PDT/PST

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

If I load 
  http://tests.themasta.com/tinderboxpushlog/?tree=TraceMonkey
then it shows the two pushes from today (31b83d5a9e36, 37a3eec57fab) with the build results. If I use the "go back 12 hours" arrow then 31b83d5a9e36 is shown, when 458b9ca9f777 should be shown. I'm waiting for both data sources to finish loading before using the arrow.

Comment 1

[Arpad Borsos [:Swatinem]]

I just found out when working on bug 571476 that pushlog expects MVT (mountain view time) timestamps, whereas the history function generates local timestamps.

Maybe you have hit this timezone bug, which timezone are you?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

NZST/NZDT, +19 to +21 hours on Mountain View

Comment 3

[Arpad Borsos [:Swatinem]]

-12 hours history +19 hours timezone = ahead with 7 hours. Really seems like the cause for seeing only the newer one of the pushes you had before.

I copy/pasted the wrong bug id there, I have a fix in bug 576489, may take some time to land though.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Glad to have a diagnosis at least. Do bear
 http://blog.mozilla.com/nthomas/2010/07/01/data-for-builds-in-progress/
in mind when refactoring. We're moving towards that being available on demand (instead of a data dump every 5 mins), and also querying for builds by revision.

Comment 5

[Arpad Borsos [:Swatinem]]

Attachment: patch

I’m rather going to split bug 576489 up into smaller more manageable pieces. This can be fixed now very easily.

Comment 6

[Arpad Borsos [:Swatinem]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/85bc32c24baf