544433 - 64-bit Mac OS X builds have broken plugin architecture detection

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

64-bit Mac OS X builds have broken plugin detection. Gecko does not look for the correct type of mach-o binary header (MH_MAGIC_64). Additionally, we assume that any universal binary has a compatible architecture without actually checking.

Comment 1

[Josh Aas]

Attachment: fix v1.0

As of Mac OS X 10.5 there is a CFBundle function that does exactly what we want so that we don't have to manually analyze mach headers - CFBundlePreflightExecutable. We should just use that and get rid of the code path for plugins that are not bundles. I don't think there are any plugins that aren't bundles any more.

Comment 2

[Josh Aas]

Note that this isn't the only reason plugins won't load in 64-bit builds - bug 544435 is also a problem.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Josh, I've just started testing this, but I already have a suggestion:

Why not make your changes specific to 64-bit builds, and leave
existing code the same for 32-bit builds?  This would be much less
likely to cause compatibility problems -- plugin vendors who make the
transition to 64-bit will find making their plugin a bundle is the
least of their problems :-)

Comment 4

[Josh Aas]

I don't think it is worth having two code paths. There aren't a lot of subtle issues here - the mach header matches or it doesn't, the new code works or it doesn't. The old code is broken in 32-bit mode too, see bug 544437.

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 425391 [details] [diff] [review]
fix v1.0

OK.  Then this is fine with me.

If we do have compatibility problems (with existing 32-bit plugins,
which I agree is unlikely), we can always come back later to fix them.

Comment 6

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/fc3d32011d31