Corrupt zip file isn't detected on upload



9 years ago
3 years ago


(Reporter: TheOne, Assigned: andy+bugzilla)




(Whiteboard: [ReviewTeam], URL)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: 

When using the diff tool on the page above, the following error message occurs:

Something went horribly wrong! Please file a bug mentioning the addon you were trying to diff

Reproducible: Always

Steps to Reproduce:
1. Visit the url above
2. Navigate to content/pilferEngine.js
3. See the error message


9 years ago
OS: Windows 7 → Other
Hardware: x86 → Other
Whiteboard: [required amo-editors]
Checked and looks like the 1.25 version of the extension is a broken zip file. I think this message can come up for a number of reasons. Maybe we should replace the message with something more meaningful like the zip file is broken or missing?
Ever confirmed: true

Comment 2

9 years ago
7zip didn't warn about a corrupt zip file.
Neither did BeyondCompare, which I used to diff the files on my machine. And at least BeyondCompare should have shown me a warning because it diff'ed every single file in the zip.
It does look like there's something wrong with the file. I got an error when trying to uncompress it on Mac OS X. You'll notice that several of the files throw the error, and a couple work fine, which makes me think the file was only partially extracted.

You'll also notice that the View Content tool is also failing for the same files, giving a File Not Found error.

The file can't be installed, either.

So, I think the real bug here is that the extraction process clearly failed at some point, and this wasn't detected in the upload and validation process. This should definitely be fixed, although it's relatively minor because we can detect the corrupt zip in the editor tools, through an error.
Severity: normal → minor
Priority: -- → P4
Summary: Something went horribly wrong! when using diff tool. → Corrupt zip file isn't detected on upload
Target Milestone: --- → 5.8
OS: Other → All
Hardware: Other → All
Yes, the most likely cause for failure here is corruption.  The library that is trying to open the file is Archive_Zip.
Target Milestone: 5.8 → Future
Is that going to be replaced in Zamboni?

this is giving the same error.  7Zip (via WinMerge) doesn't give any zip errors and seems to install in Firefox fine also.
New tools should fix this up.  Andy - can you double check?
Assignee: nobody → amckay
Target Milestone: Future → Q2 2011
Is this done?
Target Milestone: Q2 2011 → 6.0.10

Comment 10

8 years ago
If there's a problem in the uploaded zip file is corrupt, we won't unzip and the user will get an error. There will be a more detailed error in the logs.

For corrupt files inside the uploaded file, the viewer just won't expand them as was found in bug 653874.

If a user uploads a corrupt zip, the uploader will catch that, it uses the same code.

I think we should be good.
Last Resolved: 8 years ago
Resolution: --- → FIXED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: → Graveyard
You need to log in before you can comment on or make changes to this bug.