Closed Bug 544479 Opened 10 years ago Closed 10 years ago

Compile debug winmo shell with VFP support

Categories

(Tamarin Graveyard :: Build Config, defect, P3)

ARM
Windows Mobile 6 Professional
defect

Tracking

(Not tracked)

VERIFIED FIXED
flash10.1

People

(Reporter: brbaker, Assigned: brbaker)

Details

Attachments

(1 file, 2 obsolete files)

ARM fpu is now a runtime switch (-Darm_vfp) and is not controlled by a compile time setting. Remove the switch from the cross-compile script and remove from the build system.
Flags: flashplayer-triage+
Attached patch Remove arm-fpu from buildbot (obsolete) — Splinter Review
do not need to compile a specific shell from fpu support, now a runtime switch
Attachment #425461 - Flags: review?(cpeyer)
Remove the --enable-arm-fpu from the cross-platform compilation script
Attachment #425462 - Flags: review?(stejohns)
Comment on attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

Actually, we probably want to keep this: the runtime flag controls what nanojit emits. But the compiletime flag controls what the intrinsics baked into the code itself use. Compiling (say) MathUtils.cpp without VFP support would fall back to softfloat and slow down lots of code.

In fact, we should probably add another flag to allow the compiletime ARM_ARCH setting...
Attachment #425462 - Flags: review?(stejohns) → review-
So should we still be compiling 2 version of the ARM shell then? 

1) without --enable-arm_fpu which we then test as a Softfloat build
2) with --enable-arm_fpu that is tested with -Darm_vfp
Attachment #425461 - Attachment is obsolete: true
Attachment #425489 - Flags: review?(cpeyer)
Attachment #425461 - Flags: review?(cpeyer)
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
OS: All → Windows Mobile 6 Professional
Summary: Remove the --enable-arm-fpu from the build scripts → Compile debug winmo shell with VFP support
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.1
Comment on attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

--enable-arm-fpu needs to stay, patch is dead
Attachment #425462 - Attachment is obsolete: true
Attachment #425489 - Flags: review?(cpeyer) → review+
Comment on attachment 425489 [details] [diff] [review]
Compile debug shell with FPU support on winmo

Pushed patch:
tr-argo: 3680:1cf841782b27
tr: 3776:1cf841782b27, 3780:c5dd73a6030b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.