Compile debug winmo shell with VFP support

VERIFIED FIXED in flash10.1

Status

Tamarin
Build Config
P3
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Brent Baker, Assigned: Brent Baker)

Tracking

unspecified
flash10.1
ARM
Windows Mobile 6 Professional
Bug Flags:
flashplayer-qrb +
flashplayer-triage +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
ARM fpu is now a runtime switch (-Darm_vfp) and is not controlled by a compile time setting. Remove the switch from the cross-compile script and remove from the build system.
Flags: flashplayer-triage+
(Assignee)

Comment 1

8 years ago
Created attachment 425461 [details] [diff] [review]
Remove arm-fpu from buildbot

do not need to compile a specific shell from fpu support, now a runtime switch
Attachment #425461 - Flags: review?(cpeyer)
(Assignee)

Comment 2

8 years ago
Created attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

Remove the --enable-arm-fpu from the cross-platform compilation script
Attachment #425462 - Flags: review?(stejohns)

Comment 3

8 years ago
Comment on attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

Actually, we probably want to keep this: the runtime flag controls what nanojit emits. But the compiletime flag controls what the intrinsics baked into the code itself use. Compiling (say) MathUtils.cpp without VFP support would fall back to softfloat and slow down lots of code.

In fact, we should probably add another flag to allow the compiletime ARM_ARCH setting...
Attachment #425462 - Flags: review?(stejohns) → review-
(Assignee)

Comment 4

8 years ago
So should we still be compiling 2 version of the ARM shell then? 

1) without --enable-arm_fpu which we then test as a Softfloat build
2) with --enable-arm_fpu that is tested with -Darm_vfp
(Assignee)

Comment 5

8 years ago
Created attachment 425489 [details] [diff] [review]
Compile debug shell with FPU support on winmo
Attachment #425461 - Attachment is obsolete: true
Attachment #425489 - Flags: review?(cpeyer)
Attachment #425461 - Flags: review?(cpeyer)
(Assignee)

Updated

8 years ago
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
OS: All → Windows Mobile 6 Professional
Summary: Remove the --enable-arm-fpu from the build scripts → Compile debug winmo shell with VFP support

Updated

8 years ago
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.1
(Assignee)

Comment 6

8 years ago
Comment on attachment 425462 [details] [diff] [review]
Remove arm-fpu from x-platform compile

--enable-arm-fpu needs to stay, patch is dead
Attachment #425462 - Attachment is obsolete: true

Updated

8 years ago
Attachment #425489 - Flags: review?(cpeyer) → review+
(Assignee)

Comment 7

8 years ago
Comment on attachment 425489 [details] [diff] [review]
Compile debug shell with FPU support on winmo

Pushed patch:
tr-argo: 3680:1cf841782b27
tr: 3776:1cf841782b27, 3780:c5dd73a6030b
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.