Closed
Bug 544600
Opened 14 years ago
Closed 14 years ago
Accessibility should check for the bogus br node used by the editor directly
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a2
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file, 1 obsolete file)
|
3.02 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
Accessibility currently relies on a hack to detect the bogus br node which the editor uses to represent empty values. This is a hack, and it makes finding all of the places where this type of br node is being manipulated harder. This br node has the nsGkAtoms::mozeditorbogusnode attribute set to true, so we can query for that attribute value directly.
Attachment #425574 -
Flags: review?(bolterbugz)
|
Assignee | |
Comment 1•14 years ago
|
||
Ah, forgot to refresh the patch...
Attachment #425574 -
Attachment is obsolete: true
Attachment #425575 -
Flags: review?(bolterbugz)
Attachment #425574 -
Flags: review?(bolterbugz)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 425575 [details] [diff] [review] Patch (v1.1) r=me. This makes it clearer what (hackiness) is going on. Thanks. It might be a little less performant (+AttrValueIs), but I'd take it.
Attachment #425575 -
Flags: review?(bolterbugz) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/708026b98bc6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
You need to log in
before you can comment on or make changes to this bug.
Description
•