Closed Bug 544623 Opened 12 years ago Closed 12 years ago

IPDL: Shmem buffers should be shared across actor tree

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Assigned: dougt)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently they're per actor that uses shmem.  That scheme makes it awkward to create a buffer with one actor, and then use it with another.
Attached patch WIP (obsolete) — Splinter Review
Patch works (according to Joe), but it needs error handling before review.
this landed.  leaving open for "error handling before review"
maybe all of this didn't land, or was backed out by a merge?
Attached patch patch v.2Splinter Review
Attachment #425608 - Attachment is obsolete: true
Attachment #434024 - Flags: review?(bent.mozilla)
Comment on attachment 434024 [details] [diff] [review]
patch v.2

Looks good, some of the comments that try to outline the generated code aren't exactly correct (variable names, forgot one forget()), but no big deal.
Attachment #434024 - Flags: review?(bent.mozilla) → review+
http://hg.mozilla.org/projects/electrolysis/rev/2e3c323495c2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: nobody → doug.turner
You need to log in before you can comment on or make changes to this bug.