Closed
Bug 544712
Opened 14 years ago
Closed 14 years ago
Update GeckoUtils to use latest Gecko API
Categories
(Camino Graveyard :: Page Layout, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chris, Assigned: chris)
Details
(Whiteboard: [cm192test])
Attachments
(1 file)
1.62 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Gecko 1.9.1 and later no longer have GetClientWidth and GetScrollHeight as functions of nsIDOMNSHTMLElement. To move to the new API, we need to replace instances of nsIDOMNSHTMLElement in GeckoUtils with nsIDOMNSElement, which does have those functions. Note that we can't do this on our 1.9.0 tree.
Attachment #425674 -
Attachment is patch: true
Attachment #425674 -
Attachment mime type: application/octet-stream → text/plain
Assignee: nobody → trendyhendy2000
Whiteboard: [1.9.x]
I wonder if this is why stand-alone SVGs don't thumbnail on 1.9.2?
Whiteboard: [1.9.x]
Version: Trunk → 1.9.2 Branch
(In reply to comment #1) > I wonder if this is why stand-alone SVGs don't thumbnail on 1.9.2? That's filed as bug 548485, btw.
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 425674 [details] [diff] [review] Update GeckoUtils Changing the QueryInterface for the element should be enough.
Attachment #425674 -
Flags: superreview?(stuart.morgan+bugzilla)
(In reply to comment #2) > (In reply to comment #1) > > I wonder if this is why stand-alone SVGs don't thumbnail on 1.9.2? Could also be bug 552240, I suppose. > That's filed as bug 548485, btw. And bug 549052 on similar MathML weirdness.
Comment 5•14 years ago
|
||
Comment on attachment 425674 [details] [diff] [review] Update GeckoUtils sr=smorgan
Attachment #425674 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed in the test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/b9e4f0859c3d
Status: NEW → ASSIGNED
Whiteboard: [cm192test]
http://hg.mozilla.org/camino/rev/78794231fdb2
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•