When creating content from a XUL template, the template builder currently marks *all* newly created elements as "may require more work". This is silly, because the template builder can very cheaply determine that it's building a leaf element (does the template from which its copying have zero kids?), and initialize the newly created element as "no work required". Doing so avoids a wasted trip through the template builder at a later point in time, only to find that no work needed to be done! It turns out that this is accounting for about 6% of the time (after applying hyatt's prototype optimization, attribute minimization from bug 53627, and removing nsStyleUtils::IsSimpleXLink per bug 53620) spent during thread pane scrolling. I'll attach a brain-dead patch in a sec...
Created attachment 15707 [details] [diff] [review] see if we're at the leaf in the template; if so, mark the generated content as complete
Looks correct. r=hyatt.
Looks good to me too. r=rjc
Fix checked in on tip. Leaving bug open in hopes of getting in on RTM branch
Whiteboard: [rtm+] FIX IN HAND → [rtm+] FIXED ON TRUNK
Marking "needinfo." Will reconsider for inclusion once there is a reviewed and super reviewed patch.
Whiteboard: [rtm+] FIXED ON TRUNK → [rtm++] FIXED ON TRUNK
Oops. I made a mistake while updating this bug yesterday. In our conversation about it, we decided to give th bug an RTM++. Please go ahead and check this in.
Fix checked in on the branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Just nodding my head and trying not to look too stupid here ... verified fixed.
Status: RESOLVED → VERIFIED
Whiteboard: [rtm++] FIXED ON TRUNK → [rtm++]
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.