544750 - Comment for String class refers to nonexistent "kDirect" string type

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Description

[Mike Morearty]

The lengthy comment at the top of class String in StringObject.h needs some updating.  It has several references to a "kDirect" string type, but in fact no such string type exists; the string types that do exist are kDynamic, kStatic, and kDependent.

I'm not too familiar with the String class, so I don't know what the proper fix is.  It might be as simple as changing kDirect to kDynamic, but I'm not sure about that: The description says, "The most common is the kDirect type, meaning that the string data follows the instance data," but I am not sure that's an accurate description of the kDynamic type.

Also, there is one other reference to "kDirect" in another comment farther down in the file.

Comment 1

[Mike Morearty]

Attachment: Proposed patch

I'm now much more familiar with all the details of the StringObject implementation than I was when I logged this bug, so I'm comfortable rewriting the comment myself.  It's a pretty small change.

Steven would really be the right person to review this, but since he's out, Edwin, maybe you can take a look.

Comment 2

[Edwin Smith]

pushed
http://hg.mozilla.org/tamarin-redux/rev/6f1e91a6860c