544858 - Adjust required Lightning version for GData provider on mozilla-1.9.2/mozilla-central

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Simon Paquet [:sipaq]]

Currently the GData provider 0.7pre builds from comm-central/mozilla-central cannot be installed into current Lanikai (3.1a1 or 3.1b1pre) builds, because it requires at least Lightning 1.1a1pre.

http://hg.mozilla.org/comm-central/file/20f0d18ef10b/calendar/providers/gdata/install.rdf#l78

We should follow what was done in bug 543359 and add appropriate #ifdef statements in the install.rdf file of the GData provider. 

The required Lightning minversion on comm-central/mozilla-central should remain at Lightning 1.1a1pre. The required Lightning minversion on comm-central/mozilla-1.9.2 builds should be adjusted to 1.0b2pre.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: patch for comm-central

Comment 2

[Steffen Wilberg]

Comment on attachment 426278 [details] [diff] [review]
patch for comm-central

>     <em:targetApplication>
>       <Description>
>         <!-- Sunbird -->
>         <em:id>{718e30fb-e89b-41dd-9da7-e25a45638b28}</em:id>
>+#ifdef MOZILLA_1_9_2_BRANCH
>+        <em:minVersion>1.0b2pre</em:minVersion>
>+#else
>         <em:minVersion>1.1a1pre</em:minVersion>
>+#endif
>         <em:maxVersion>@CALENDAR_VERSION@</em:maxVersion>
Can somebody explain to me why @CALENDAR_VERSION@ isn't used for minVersion as well, which is 1.0b2pre on the MOZILLA_1_9_2_BRANCH and 1.1a1pre on moz-central?
The branch/trunk ifdefs are already in the Makefile:
http://mxr.mozilla.org/comm-central/source/calendar/providers/gdata/Makefile.in#53
Or do yo need to hardcode those values?

>       </Description>
>     </em:targetApplication>
>     <em:targetApplication>
>       <Description>
>         <!-- Thunderbird -->
>         <em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id>
>+#ifdef MOZILLA_1_9_2_BRANCH
>         <em:minVersion>3.1a1pre</em:minVersion>
>+#else
>+        <em:minVersion>3.2a1pre</em:minVersion>
>+#endif
>         <em:maxVersion>@THUNDERBIRD_VERSION@</em:maxVersion>
And why isn't @THUNDERBIRD_VERSION@ used for minVersion as well, which is 3.1a1pre on the MOZILLA_1_9_2_BRANCH and 3.2a1pre on moz-central?

>       </Description>
>     </em:targetApplication>
>     <em:targetApplication>
>       <Description>
>         <!-- SeaMonkey -->
>         <em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id>
>         <em:minVersion>2.1a1pre</em:minVersion>
>         <em:maxVersion>@SEAMONKEY_VERSION@</em:maxVersion>
And @SEAMONKEY_VERSION@ for minVersion?

>       </Description>
>     </em:targetApplication>
> 
>     <em:requires>
>       <Description>
>         <!-- Lightning (also Sunbird via extension stub) -->
>         <em:id>{e2fda1a4-762b-4020-b5ad-a41df1933103}</em:id>
>+#ifdef MOZILLA_1_9_2_BRANCH
>+        <em:minVersion>1.0b2pre</em:minVersion>
>+#else
>         <em:minVersion>1.1a1pre</em:minVersion>
>+#endif
>         <em:maxVersion>@CALENDAR_VERSION@</em:maxVersion>
@CALENDAR_VERSION@ for minVersion again.

>       </Description>
>     </em:requires>

Comment 3

[Stefan Sitter [:ssitter]]

Steffen, minVersion is set to a fixed version to allow testing in all supported builds, not just the latest nightly build, e.g. both Lanikai Alpha 1 release build and Lanikai 3.1b1pre nightly build.

Comment 4

[Steffen Wilberg]

OK, so you want minVersion to remain at the hardcoded value even when @THUNDERBIRD_VERSION@ gets bumped to a later version. Makes sense.

Should Gdata have a higher <em:version> when built from trunk, like 0.8pre?

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 426278 [details] [diff] [review]
patch for comm-central

Yes, lets bump the version to 0.8pre on trunk. With this changed,  go ahead and check in any time you like.

Comment 6

[Stefan Sitter [:ssitter]]

Pushed to comm-central <https://hg.mozilla.org/comm-central/rev/ed6765f30ddc> with minor changes --> FIXED.