544887 - Omnia 2: Soft keyboard pop-up is on top of search engine bar in the awesome bar on first run

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2.2pre) Gecko/20100208 Namoroka/3.6.2pre Fennec/1.0a4pre

Steps to Reproduce:
1. Open Fennec
2. Click on the url bar to open the awesome bar

Actual Results:
The softkb menu bar shows on top of the search bar

Expected Results:
The search bar should show on top of the soft keyboard, when instanced, and the menu bar when the softkb is not instanced.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: screen shot

just want to confirm that this is the situation you're seeing

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 425881 [details] [diff] [review]
patch

Add a comment above the +  HideWindowChrome(aFullScreen); call that states that this is what the base window does.

wanna try removing:
   MoveWindow(mWnd, rc.left, rc.top, rc.right-rc.left, rc.bottom-rc.top, TRUE);

+      if (SipGetInfo(&sipInfo)) 

Extra white space

In nsWindow::MakeFullScreen(PRBool aFullScreen), please wrap those lines to ~80 chars.  easier to read.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch, with nits addressed

carrying dougt's review

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b24909ba494f

Comment 6

[Aakash Desai [:aakashd]]

This is resolved...

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2.2pre) Gecko/20100208 Namoroka/3.6.2pre Fennec/1.0a4pre