544937 - custom personas from before the fix for bug 532577 don't have IDs

Status: RESOLVED WONTFIX

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Custom personas aren't assigned IDs, and this breaks Firefox's add-on manager (per bug 544753).

Personas should assign custom personas a random ID (perhaps a GUID using Firefox's built-in GUID generator) per the add-on manager's expectation that all personas have an ID, both to fix the add-ons manager (until it is fixed in Firefox to handle this edge case) and so such bugs don't occur in the future.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Hmm, actually the custom persona editor assigns ID "0" to custom personas as of
the latest releases per bug 532577, which was about fixing issues with the way
Personas interacts with the add-ons manager.  However, that change didn't get
applied to existing custom personas.

mossop: is ID "0" a reasonable value?

Comment 2

[Dave Townsend [:mossop]]

"0" should be fine, I think we accept basically any string it just needs to be unique of course.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Ok, morphing this bug to focus only on custom personas from before the fix for bug 532577.  Having said that, I'm not sure whether we want to fix it, as I expect the number of users of custom personas from that era to be pretty small.

Comment 4

[Ryan Doherty (:rdoherty)]

wontfixing, odds are few users (and shrinking) will ahve this issue.