android test proxy script reverse the order of vm arguments

VERIFIED FIXED in flash10.1

Status

Tamarin
Tools
P3
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Dan Schaffer, Assigned: Dan Schaffer)

Tracking

unspecified
flash10.1
x86
Mac OS X
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.08 KB, application/octet-stream
Rob Winchell
: review+
Details
(Assignee)

Description

8 years ago
the android_shell.sh script reverse the arguments
- improve android script to copy all abc files and clean up after test finishes
- mark android known failures in testconfig.txt and exclude the slow running tests
(Assignee)

Comment 1

8 years ago
Created attachment 426023 [details] [diff] [review]
patch
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED
Attachment #426023 - Flags: review?(brbaker)
(Assignee)

Updated

8 years ago
Attachment #426023 - Flags: review?(rwinchel)

Comment 2

8 years ago
Comment on attachment 426023 [details] [diff] [review]
patch

Need to be able to maintain application arguments that are passed after the .abc file

$AVM test.abc -- foobar

This gets converted to:
$AVM -- foobar test.abc
Attachment #426023 - Flags: review?(brbaker) → review-
(Assignee)

Comment 3

8 years ago
yeah good catch.  I'll work on a version that preserves the order for all args.

Updated

8 years ago
Assignee: dschaffe → nobody
Component: Virtual Machine → Tools
Flags: flashplayer-qrb+
Priority: -- → P3
QA Contact: vm → tools
Target Milestone: --- → flash10.1

Updated

8 years ago
Assignee: nobody → dschaffe
(Assignee)

Comment 4

8 years ago
Created attachment 427810 [details]
patch

updated patch for adding android configuration to acceptance tests.  copy all abc files to the device, run the abc, cleanup abc on device.
Attachment #426023 - Attachment is obsolete: true
Attachment #427810 - Flags: review?(rwinchel)
Attachment #426023 - Flags: review?(rwinchel)

Updated

8 years ago
Attachment #427810 - Flags: review?(rwinchel) → review+
(Assignee)

Comment 5

8 years ago
pushed in 3864:f687ea8698c0, http://hg.mozilla.org/tamarin-redux/rev/f687ea8698c0
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.