545173 - Weave Client on the iPhone Crashes While Syncing

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Richard A Milewski[:richard]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: Weave Client for iPhone compiled from Mike Hanson's First Checkin

Worked great for two days.  Now consistently crashes.  When run in the XCode debugger, GDB reports "SIGABRT".

Reproducible: Always

Steps to Reproduce:
1.Open Weave Client on iPhone
2.Wait until sync starts
3.Crash!
Actual Results:  
Client Crashes

Expected Results:  
Client Synced

Crash Log Attached

Comment 1

[Richard A Milewski[:richard]]

Attachment: Crash Log from iPhone

Comment 2

[Michael Hanson]

The relevant lines are:

9   libobjc.A.dylib               	0x00006e54 objc_exception_throw + 104
10  CoreFoundation                	0x00026b2c +[NSException raise:format:arguments:] + 76
11  CoreFoundation                	0x00026acc +[NSException raise:format:] + 24
12  Foundation                    	0x00045220 -[NSCFDictionary setObject:forKey:] + 192
13  Weave                         	0x00008b00 -[Stockboy updateTabs] (Stockboy.m:202)
14  Weave                         	0x0000866e -[Stockboy restockEverything] (Stockboy.m:148)
15  Foundation                    	0x00053ac6 -[NSThread main] + 42
16  Foundation                    	0x00001d0e __NSThread__main__ + 852

The relevant line in updateTabs is [userTabSets setObject:tabSet forKey:tabSetID].  Not entirely clear why that would raise an exception yet.

Comment 3

[Michael Hanson]

NSMutableDictionary docs: Raises an NSInvalidArgumentException if aKey or anObject is nil. If you need to represent a nil value in the dictionary, use NSNull.

That's a possibility.

Comment 4

[Michael Hanson]

Richard told me that he synced a client machine that had no tabs prior to this crash.  Strongly suspect that this one is due to an empty tab set.

Comment 5

[Richard A Milewski[:richard]]

Tried to reproduce the crash by syncing a client machine with no tabs.  Was unable to reproduce the crash.  The machine with no tabs simply did not appear in the tabs list.

Comment 6

[Dan Walkowski]

I believe this to be fixed. There was insufficient error case handling for malformed JSON objects.

Comment 7

[Tony Chung [:tchung]]

Verified fix on beta 11 build

Comment 8

[Tony Chung [:tchung]]

Moving FFHome-related bugs to new component -> Firefox Home