545253 - Do not display flags as editable when you cannot edit attachment attributes

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

Bugzilla 3.6 has a confusing UI when you are not allowed to edit an attachment. Flags are editable, but committing changes has no effect: flag changes are silently ignored. Flags should be displayed as read-only in this case.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Granting myself review as module owner.

Comment 2

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/attachment/edit.html.tmpl
modified template/en/default/flag/list.html.tmpl
Committed revision 6975.


Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified template/en/default/attachment/edit.html.tmpl
modified template/en/default/flag/list.html.tmpl
Committed revision 6969.

Comment 3

[ali rayl]

(In reply to Frédéric Buclin from comment #0)
> Bugzilla 3.6 has a confusing UI when you are not allowed to edit an
> attachment. Flags are editable, but committing changes has no effect: flag
> changes are silently ignored. Flags should be displayed as read-only in this
> case.

I'm not seeing the problem where flag changes are silently ignored when this patch is not present. This patch's presence, however, breaks the workflow of asking someone without system-wide editbugs permissions for a patch review.

Comment 4

[Frédéric Buclin]

(In reply to ali rayl from comment #3)
> (In reply to Frédéric Buclin from comment #0)
> This patch's presence, however, breaks the workflow of
> asking someone without system-wide editbugs permissions for a patch review.

As I said, this is only a UI thing. The backend code would reject your request anyway. What you want is bug 294021.

Comment 5

[ali rayl]

(In reply to Frédéric Buclin from comment #4)
> As I said, this is only a UI thing. The backend code would reject your
> request anyway. What you want is bug 294021.

The back-end code isn't rejecting the request. If I back out this patch from our installation without making any other changes, users A and B are able to change flag states and have those changes persist.