545316 - Make 7zip library return archive information

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

Fennec installer needs to know how much space is needed for the extracted files. Current implementation of 7zip library has only archive extraction functions.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Patch

Added SzGetArchiveInfo function.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 426423 [details] [diff] [review]
Patch


>+
>+/**
>+ * Get information about 7z-archive
>+ *
>+ * @param archiveFileName    Name of the archive
>+ *
>+ * Output parameters:
>+ * @param pUncompressedSize  Pointer to 64 bit integer for the total uncompressed size
>+ * @param pNumberOfFiles     (optional) Pointer to a number of files in the archive
>+ * @param pNumberOfDirs      (optional) Pointer to a number of directories in the archive
>+ */
>+int SzGetArchiveInfo(const WCHAR *archiveName,
>+                     ULONGLONG *pUncompressedSize, DWORD *pNumberOfFiles, DWORD *pNumberOfDirs)
>+{
>+  return SzGetSfxArchiveInfo(archiveName, 0, pUncompressedSize, pNumberOfFiles, pNumberOfDirs);
>+}
Do you need this helper function?  I'd rather we don't add it.

r+ with removed

Comment 3

[Alex Pakhotin (:alexp)]

(In reply to comment #2)
> >+int SzGetArchiveInfo(const WCHAR *archiveName,
> >+                     ULONGLONG *pUncompressedSize, DWORD *pNumberOfFiles, DWORD *pNumberOfDirs)

> Do you need this helper function?  I'd rather we don't add it.

I just try to keep the library a bit more generic, i.e. work with regular .7z archives. It has already proved to be useful when Joel needed to extract archive on the device for testing purposes.

SzGetSfxArchiveInfo works for regular archives when sfxStubSize=0, just having a separate "generic" function would be easier to understand for a potential user of the library.

Comment 4

[Alex Pakhotin (:alexp)]

Attachment: Patch v1+

Removed the helper function.

Comment 5

[Justin Wood (:Callek)]

Pushed as: http://hg.mozilla.org/mozilla-central/rev/64e1cfd8ba01