545330 - Crash [@ PresShell::Destroy] on exit after failed Print Preview of XUL document

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Mats Palmgren (inactive)]

Crash [@ PresShell::Destroy] on exit after failed Print Preview of XUL document.

STEPS TO REPRODUCE
1. load URL
2. File->Print Preview
3. dismiss the error dialog
4. File->Quit

ACTUAL RESULTS
Segmentation fault

REGRESSION RANGE
2009-12-11-03 -- 2009-12-12-03
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9af2a428dcb1&tochange=d379a17cbf8f
I'm guessing it was caused by bug 487667.

Comment 1

[Mats Palmgren (inactive)]

Attachment: fwiw, this is what valgrind says

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This should work well enough.

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 426199 [details] [diff] [review]
patch

>+      this._callback.onEnter();
>+      this._callback.onExit();

Alternatively, we could skip the onEnter and require that onExit deals.
In this case onExit in browser.js needs something like:
    if (gInPrintPreviewMode) {
      gInPrintPreviewMode = false;
      this._toggleAffectedChrome();
    }
which avoids the flickering from toggling the chrome off/on.

Either way is fine with me though, r=mats

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/d532977c11bf