Closed Bug 545368 Opened 14 years ago Closed 14 years ago

firefox doesn't theme tab focus rings

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ht990332, Assigned: ventnor.bugzilla)

References

Details

Attachments

(3 files, 1 obsolete file)

gtk+
13.71 KB, image/png
Details
firefox
18.80 KB, image/png
Details
For checkin
6.21 KB, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100207 Namoroka/3.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100207 Namoroka/3.6

last few clearlooks and also murrine gtk+ engines theme tab focus rings.
Firefox still doesn't. I would be cool if firefox also started to theme those.

I'll attack screenies for comparison.

Reproducible: Always
Attached image gtk+ — 

    
    

    
  

      
      
      
      

        Attached image
          
        firefox
        — 
      

    


  

    
    

    
  
wasn't this bug 423606 (or do those themes use a different method now ?) ?

    
    

    
  
(In reply to comment #3)
> wasn't this bug 423606 (or do those themes use a different method now ?) ?

A different thing because I'm using firefox 3.6 and the bug you linked to was closed a long time ago.

    
    

    
  
That was what I meant : wasn't this supposed to have been fixed a long time ago ?

    
    

    
  
I honestly don't know. At the moment, firefox respects most gtk-engine skinning up to focus rings in buttons, etc.. Only still visible part that still needs to be skinned is focus rings on tabs. It's visible if you see the attached screenshots.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch (obsolete)
        — 
          — Splinter Review
      

    


  
Assignee: nobody → ventnor.bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true

        Attachment #426416 -
        Flags: review?(roc)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        For checkin
        — 
          — Splinter Review
      

    


  
Fix a comment for clarity.

        Attachment #426416 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/3493c7f8e208
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Depends on: 547678

    
  
Blocks: 479961

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: