545403 - [HTML5][Patch] dom/tests/mochitest/dom-level1-core/test_hc_documentgetdoctype.html fails

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Henri Sivonen (:hsivonen)]

dom/tests/mochitest/dom-level1-core/test_hc_documentgetdoctype.html fails. It expects the doctype name in different case.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Change the test to accept both upper and lower case

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Change the test to accept both upper and lower case, with proper indent

The test and the old parser were previously changed to match a now-obsolete snapshot of the WHATWG spec. Now HTML5 has changed to lower-case the doctype name instead of upper-casing it.

Comment 3

[Ben Newman (:bnewman) (:benjamn)]

Comment on attachment 428390 [details] [diff] [review]
Change the test to accept both upper and lower case, with proper indent

>-                        // modified to uppercase per WHATWG
>-			assertEquals("nodeName","HTML",docTypeName);
>+			// Modified to allow lower case for the HTML5 parser and upper case for the old parser
>+			assertTrue("nodeName", "HTML" == docTypeName || "html" == docTypeName);

Alternatively, if you want to keep readability of assertion failure messages, you could do

    assertEquals("nodeName", "html", docTypeName.toLowerCase());

Your call.

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to comment #3)
> (From update of attachment 428390 [details] [diff] [review])
> >-                        // modified to uppercase per WHATWG
> >-			assertEquals("nodeName","HTML",docTypeName);
> >+			// Modified to allow lower case for the HTML5 parser and upper case for the old parser
> >+			assertTrue("nodeName", "HTML" == docTypeName || "html" == docTypeName);
> 
> Alternatively, if you want to keep readability of assertion failure messages,
> you could do
> 
>     assertEquals("nodeName", "html", docTypeName.toLowerCase());
> 
> Your call.

Thanks.

Pushed as is:
http://hg.mozilla.org/mozilla-central/rev/ee56d65affa3

toLowerCase() would allow "hTmL", which is unwanted.