Closed
Bug 545506
Opened 14 years ago
Closed 14 years ago
Fix the custom header/footer dialog in GTK's print dialog
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | .9-fixed |
People
(Reporter: ventnor.bugzilla, Assigned: ventnor.bugzilla)
Details
Attachments
(1 file)
|
3.73 KB,
patch
|
roc
:
review+
christian
:
approval1.9.2.7-
christian
:
approval1.9.2.9+
|
Details | Diff | Splinter Review |
There are a lot of problems with the custom header/footer prompt we show on GTK's native print dialog. 1) Pressing Enter doesn't confirm the dialog by default. 2) There is a horizontal separator. 3) The dialog isn't actually modal. 3) is the most important, but I'd thought I'd fix up the others since they're one-liners.
Attachment #426334 -
Flags: review?(roc)
Attachment #426334 -
Flags: review?(roc) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6f676b618380
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 2•14 years ago
|
||
Comment on attachment 426334 [details] [diff] [review] Patch Would like to get this in 1.9.2.x, we have customer complaints about issues 1 and 3 (from the description).
Attachment #426334 -
Flags: approval1.9.2.7?
Comment on attachment 426334 [details] [diff] [review] Patch a=LegNeato for 1.9.2.8. Please land this on mozilla-1.9.2 default.
Attachment #426334 -
Flags: approval1.9.2.8+
Attachment #426334 -
Flags: approval1.9.2.7?
Attachment #426334 -
Flags: approval1.9.2.7-
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/755d4f42f113
status1.9.2:
--- → .8-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•