545524 - New Hook: object_validators

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[Max Kanat-Alexander]

One thing that extensions often need to do is to update or add validators for objects.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here's the hook. This modifies Bugzilla::Object to always cache the result of VALIDATORS per-request, so that the hook doesn't run every time we call set().

Comment 2

[Max Kanat-Alexander]

Attachment: v2

The first version had the potential to modify the constant's value, which could be a problem in mod_perl.

Comment 3

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Bug.pm
modified Bugzilla/Hook.pm
modified Bugzilla/Object.pm
modified extensions/Example/Extension.pm
modified extensions/Example/template/en/default/hook/global/user-error-errors.html.tmpl
Committed revision 6981

And fixed a typo after commit:

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Object.pm
Committed revision 6982.

Comment 4

[Frédéric Buclin]

Is this patch too invasive or risky to take for 3.6.3?

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> Is this patch too invasive or risky to take for 3.6.3?

  Hey, sorry, I never got back to you on this. Yeah, I think the patch would have been too invasive for any stable branch.