545621 - Adapt gloda to use new storage createAsyncStatement API

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

Our stop-gap solution for bug 519543 was to have Thunderbird-specific release branches of mozilla-1.9.1 and mozilla-1.9.2 where I hacked up storage to allow gloda to use it in a purely asynchronous fashion where the sqlite3 mutex would not be taken on the main thread.

The long-term solution is bug 507414 which introduces an explicit API that accomplishes this same goal without changing semantics out from under existing consumers.  (It is also much more comprehensive about the fix).  We need to change gloda to use this.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Andrew, how much work remains here?  What do the chances look like that this will be able to land by tomorrow night's code freeze?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 make gloda use createAsyncStatement if we have async statements available http://hg.mozilla.org/comm-central/rev/700a775e14da

To test that the async part works, one needs to have applied the patches on bug 545625.  However, this patch should still work without those patches applied, you just end up testing the other side of the conditional.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Pushed to comm-central along with its friends on bug 545625.  Even if those patches get backed out, this patch is going to stick around since it works with or without them.
http://hg.mozilla.org/comm-central/rev/700a775e14da