545626 - Mozmill: random orange with closing the current tab but not properly waiting for message display completion

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Rain [:rain1] (inactive)]

I've seen several failures of this kind on the tinderboxes.

Comment 1

[Rain [:rain1] (inactive)]

I've got this tracked down, but I'm still seeing one timeout (which I think is being caused by a double message load by the persistence code).

Comment 2

[Rain [:rain1] (inactive)]

Attachment: patch

This seems to not cause any timeouts once the patch in bug 545886 is applied.

Comment 3

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/1911acef7131

Comment 4

[Rain [:rain1] (inactive)]

Comment on attachment 426703 [details] [diff] [review]
patch

While this particular patch is npotb, this will cause timeouts unless all the
patches it depends on lands, and some of those patches _are_ part of the build,
and potentially risky. I think we should take this and suffer the timeouts on
branch.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 426703 [details] [diff] [review]
patch

Sid told me over irc that the timeouts in this case are just waitForxxx timeouts reaching their limit not timeouts as in random orange timeouts. Therefore a=Standard8 for 3.0 branch.

Comment 6

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/releases/comm-1.9.1/rev/324c4ec4e109

Comment 7

[Mark Banner (:standard8)]

Verifying test-only patch, I haven't seen this recently and the tests are generally green.