545667 - Recent patch from bug 515568 breaks webservice code in extensions

Status: RESOLVED INVALID

(Bugzilla :: WebService, defect)

Description

[David Lawrence [:dkl]]

We applied the patch from 515568 to our customized 3.4 code base and now
changes to Bugzilla::WebService::Server::handle_login() throws error that
the method is unknown.

The requested method 'bugzilla.login' was not found.

This effects all exported methods in our extensions which all worked before the patch. 

The error message in $@ in the eval portion of handle_login() is the following for the above method call:

error: Can't locate bugzilla.pm in @INC (@INC contains: /var/www/html/bugzilla/extensions . lib /var/www/html/bugzilla /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi /usr/lib/perl5/site_perl/5.8.8 /usr/lib/perl5/site_perl /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.8 /usr/lib64/perl5/vendor_perl/5.8.5/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.8.5 /usr/lib/perl5/vendor_perl /usr/lib64/perl5/5.8.8/x86_64-linux-thread-multi /usr/lib/perl5/5.8.8 /etc/httpd) at (eval 529) line 3.

We have a package named 'bugzilla' (for historical reasons) in extensions/compat_xmlrpc/code/webservice.pl that does contain a 'login' subroutine and others.

Interestingly, the $@ var has been set to an error even before the patch but was ignored. The $@ still has the above error message in it. So at some point after Bugzilla::WebServer::Server::handle_login(), the package 'bugzilla' is being loaded properly and the 'bugzilla.login' method is found and executed properly. So something just may need to be loaded earlier. 

Will investigate further and also try this test in a vanilla checkout of 3.4 to make sure it is not our changes causing problems. Unless someone can think of a fix/reason for this earlier.

Dave

Comment 1

[Frédéric Buclin]

dkl: is this bug still valid in 4.2?

Comment 2

[David Lawrence [:dkl]]

No longer have access to the code base that caused this originally. Closing as I have not seen this in recent versions.