545674 - nsMsgDBView::ReloadMessage doesn't call displayMessageChanged on the command updater

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

This causes the fun bug demonstrated in the test case. This also causes the timeout I mentioned in bug 545626.

From IRC:

<sid0> bienvenu: hm, what's happening is that when you toggle the message pane off, clearDisplay gets called, which sets the displayedMessage to null
<sid0> bienvenu: when you turn it on again, reloadMessage gets called: http://mxr.mozilla.org/comm-central/source/mail/base/content/messageDisplay.js#465
<sid0> however since reloadMessage doesn't call displayMessageChanged, displayedMessage doesn't get set back to non-null
<sid0> now, if you switch tabs and come back, makeActive gets called -- but displayMessage is null at http://mxr.mozilla.org/comm-central/source/mail/base/content/messageDisplay.js#405
<sid0> so the _second_ reloadMessage doesn't happen

Comment 1

[Rain [:rain1] (inactive)]

Attachment: patch v1.01

hm, I really should remember to take random sleep() calls out :(

Comment 2

[David :Bienvenu]

Comment on attachment 426519 [details] [diff] [review]
patch v1.01

this doesn't qimport for me...patching file mail/test/mozmill/shared-modules/test-folder-display-helpers.js
Hunk #2 FAILED at 1426
1 out of 2 hunks FAILED -- saving rejects to file mail/test/mozmill/shared-modul
es/test-folder-display-helpers.js.rej

can you double check that you're on the tip?

Comment 3

[Rain [:rain1] (inactive)]

Attachment: patch, v1.02

(sorry, this was on top of another patch in my queue)

Comment 4

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/9126fbd839d9

Comment 5

[Rain [:rain1] (inactive)]

Pushed a followup: http://hg.mozilla.org/comm-central/rev/bad8186656d8