Closed Bug 545674 Opened 12 years ago Closed 12 years ago

nsMsgDBView::ReloadMessage doesn't call displayMessageChanged on the command updater

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.1b1

People

(Reporter: rain1, Assigned: rain1)

References

Details

Attachments

(1 file, 2 obsolete files)

patch, v1.02
13.16 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
This causes the fun bug demonstrated in the test case. This also causes the timeout I mentioned in bug 545626.

From IRC:

<sid0> bienvenu: hm, what's happening is that when you toggle the message pane off, clearDisplay gets called, which sets the displayedMessage to null
<sid0> bienvenu: when you turn it on again, reloadMessage gets called: http://mxr.mozilla.org/comm-central/source/mail/base/content/messageDisplay.js#465
<sid0> however since reloadMessage doesn't call displayMessageChanged, displayedMessage doesn't get set back to non-null
<sid0> now, if you switch tabs and come back, makeActive gets called -- but displayMessage is null at http://mxr.mozilla.org/comm-central/source/mail/base/content/messageDisplay.js#405
<sid0> so the _second_ reloadMessage doesn't happen
Attachment #426517 - Flags: superreview?(bienvenu)
Attachment #426517 - Flags: review?(bienvenu)
Attached patch patch v1.01 (obsolete) — — Splinter Review 
hm, I really should remember to take random sleep() calls out :(
Attachment #426517 - Attachment is obsolete: true
Attachment #426519 - Flags: superreview?(bienvenu)
Attachment #426519 - Flags: review?(bienvenu)
Attachment #426517 - Flags: superreview?(bienvenu)
Attachment #426517 - Flags: review?(bienvenu)
Comment on attachment 426519 [details] [diff] [review]
patch v1.01

this doesn't qimport for me...patching file mail/test/mozmill/shared-modules/test-folder-display-helpers.js
Hunk #2 FAILED at 1426
1 out of 2 hunks FAILED -- saving rejects to file mail/test/mozmill/shared-modul
es/test-folder-display-helpers.js.rej

can you double check that you're on the tip?
Attachment #426519 - Flags: superreview?(bienvenu)
Attachment #426519 - Flags: superreview-
Attachment #426519 - Flags: review?(bienvenu)
Attachment #426519 - Flags: review-
Attached patch patch, v1.02 — — Splinter Review 
(sorry, this was on top of another patch in my queue)
Attachment #426519 - Attachment is obsolete: true
Attachment #426526 - Flags: superreview?(bienvenu)
Attachment #426526 - Flags: review?(bienvenu)
Attachment #426526 - Flags: superreview?(bienvenu)
Attachment #426526 - Flags: superreview+
Attachment #426526 - Flags: review?(bienvenu)
Attachment #426526 - Flags: review+
http://hg.mozilla.org/comm-central/rev/9126fbd839d9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
Blocks: 542249
You need to log in before you can comment on or make changes to this bug.