Closed Bug 545674 Opened 10 years ago Closed 10 years ago
Msg DBView::Reload Message doesn't call display Message Changed on the command updater
This causes the fun bug demonstrated in the test case. This also causes the timeout I mentioned in bug 545626. From IRC: <sid0> bienvenu: hm, what's happening is that when you toggle the message pane off, clearDisplay gets called, which sets the displayedMessage to null <sid0> bienvenu: when you turn it on again, reloadMessage gets called: http://mxr.mozilla.org/comm-central/source/mail/base/content/messageDisplay.js#465 <sid0> however since reloadMessage doesn't call displayMessageChanged, displayedMessage doesn't get set back to non-null <sid0> now, if you switch tabs and come back, makeActive gets called -- but displayMessage is null at http://mxr.mozilla.org/comm-central/source/mail/base/content/messageDisplay.js#405 <sid0> so the _second_ reloadMessage doesn't happen
hm, I really should remember to take random sleep() calls out :(
Comment on attachment 426519 [details] [diff] [review] patch v1.01 this doesn't qimport for me...patching file mail/test/mozmill/shared-modules/test-folder-display-helpers.js Hunk #2 FAILED at 1426 1 out of 2 hunks FAILED -- saving rejects to file mail/test/mozmill/shared-modul es/test-folder-display-helpers.js.rej can you double check that you're on the tip?
(sorry, this was on top of another patch in my queue)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
Pushed a followup: http://hg.mozilla.org/comm-central/rev/bad8186656d8
You need to log in before you can comment on or make changes to this bug.