545695 - show_bug.cgi: Use of uninitialized value

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Brad Johnson]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100106 Ubuntu/9.10 (karmic) Firefox/3.5.7
Build Identifier: 3.4.4

Sometimes this is printed to the error log:

show_bug.cgi: Use of uninitialized value in numeric eq (==) at Bugzilla/User.pm line 712

Looks like $warn isn't always passed in when called from edit.html.tmpl, so this line in User.pm causes the error message:

    return 0 unless $warn == THROW_ERROR;

Reproducible: Always

Comment 2

[Reed Loden [:reed]]

Actually, this isn't a dupe. It seems this bug only affects Bugzilla 3.4.

template/en/default/bug/edit.html.tmpl:377:
         [% IF NOT user.can_enter_product(bug.product) %]

Comment 3

[Frédéric Buclin]

This is the same issue. The problem reported here was due to bug 322848, which landed in Bugzilla 3.0. You don't see this bug in 3.5.3 because I fixed it in bug 526271. I simply decided to not backport it to 3.4.

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v1 (untested)

Something like this? Not sure if we actually want to throw an error, but it seems like we would...

Comment 5

[Frédéric Buclin]

Comment on attachment 426539 [details] [diff] [review]
patch - v1 (untested)

No, see my previous comment.

Comment 6

[Reed Loden [:reed]]

Did you read comment #2? This only affects 3.4. Bug 526271 "fixes" this problem, but it's not for the same reason at all.

Comment 7

[Reed Loden [:reed]]

Attachment: patch - v2 (3.4 branch)

Just fix Bugzilla/User.pm.

Comment 8

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.4/                         
modified Bugzilla/User.pm
Committed revision 6724.