Classic skin, back and forward buttons: mouse over the dropmarker, the entire button is highlighted correctly mouse over the button part itself, only that segment is highlighted, rather than raising the dropmarker with it. this is a problem. to see how it is supposed to work, you have to flip the pref on joki's hierachical :hover stuff. The back and forward menubuttons in classic are dependant on particular aspects of :hover behaviour that changed in joki's 09/14 checkin. The menubuttons were updated to work with joki's change, however this change was reverted and the menubuttons are broken again. The fix for this is to revert my changes for compliance with the hierachical :hover, and apply a robustness tweak to it to ensure it works identically with either system. (I would, however, appreciate some sort of consensus about how this is going to end up working so I don't end up scrambling to support one system or another). This is a very obvious bug as it deals with the primary navigation buttons in Navigator.
nominating for rtm.
17 years ago
Yes, let's fix this in RTM. It's annoying this regressed the last week. Ben's change basically rolls the problem file back a revision.
Ooops, this is a P2.
*** Bug 54863 has been marked as a duplicate of this bug. ***
PDT marking [rtm need info] since no patch or code review are available
patches look lengthy but it basically involves rolling the two files back two revs to get the old behaviour before I made the change. That code was well tested. I added a couple of !importants to :active rules on the buttons as well so that this code now works no matter how the hierachical hover pref is set.
r=blake on the patch (mainly just a reversion), with the obligatory note that most of this is a hack (since the fix for 5693 was turned off by default), and the added caveat that I could only test the patches on windows.
rtm+ now because it's reviewed and approved.
hyatt sez a=hyatt for this.
unclobbering the rtm+
17 years ago
PDT marking [rtm++] especially for the stretched icon problem.
fix checked in on branch and trunk.
These stretched buttons are still a problem on Mac. Win32 looks good.
reopening for the mac issue
andrew was working on a fix for this.
I'm basically taking the windows changes wholesale, but there are some additional work to get them looking right on mac. Looking into this now... I seem to crash when I choose a dropdown which is disabled.
*** Bug 55908 has been marked as a duplicate of this bug. ***
*** Bug 55889 has been marked as a duplicate of this bug. ***
Since this is a reopenage and just on mac should I clear the status whiteboard?
Created attachment 16718 [details] [diff] [review] 2 files for mac bug. buttonbindings.xml, menubutton.css
r=hewitt. seeking sr.
marking verified on mac (2000-10-11-10-MN6).
Marking verified on Mac (2001-01-02-08-Mtrunk).